Sitelet https://web.archive.org/web/20220809181552/https://github.com/scrapy/scrapy/issues/5579
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the overwrite feed option documentation #5579

Open
Gallaecio opened this issue Jul 28, 2022 · 1 comment
Open

Improve the overwrite feed option documentation #5579

Gallaecio opened this issue Jul 28, 2022 · 1 comment
Labels
docs enhancement good first issue

Comments

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Jul 28, 2022

The overwrite feed option has a different default value depending on the storage backend used, and we currently cover its default value for all backeds except for Google Cloud Storage (GCS). We should address that.

Also, since overwrite=True is a potentially data-deleting operation, it may be a good idea to mention the fact that overwrite=True in the sections about storage backends with that default value, and not just in the section about the overwrite feed option.
@limury
Copy link

@limury limury commented Aug 8, 2022 •
edited

Hi! I'd like to take on this issue. I think that GCS also does not allow appending to the storage. Also saw that the GCS initializer does not include a feed_options parameter so I'll add that!

Edit:
Completed the above and have a PR at #5593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gallaecio @limury