Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVTune integration #814
Open
VTune integration #814
Conversation
|
Native part is not included? |
vtune_integration.py
Outdated
| ll.add_symbol('__itt_task_begin_new', itt.__itt_task_begin) | ||
| ll.add_symbol('__itt_task_end_new', itt.__itt_task_end) | ||
|
|
||
| def vtune_profiling_boxing(name_handle): |
This comment has been minimized.
This comment has been minimized.
| handle = vt.ctypes_string_handle_create(b"Head\0") | ||
|
|
||
| functype_task_begin = ctypes.CFUNCTYPE(None, ctypes.c_void_p, ctypes.c_void_p) | ||
| ctypes_task_begin = functype_task_begin(itt.__itt_task_begin) |
This comment has been minimized.
This comment has been minimized.
AlexanderKalistratov
Apr 21, 2020
Collaborator
I believe it should be done in vtune.py, not here. And here just import these functions
pep8speaks
commented
Apr 22, 2020
•
added 2 commits
Apr 22, 2020
| @@ -2268,6 +2269,7 @@ def hpat_pandas_series_corr_impl(self, other, method='pearson', min_periods=None | |||
|
|
|||
|
|
|||
| @sdc_overload_method(SeriesType, 'head') | |||
| @vtune_profiling_overload(name_handle="Series_head") | |||
This comment has been minimized.
This comment has been minimized.
AlexanderKalistratov
Apr 22, 2020
Collaborator
It should be part of sdc_overload_method decorator. We can extract type name and method name from where.
This comment has been minimized.
This comment has been minimized.
AlexanderKalistratov
Apr 22, 2020
Collaborator
You actually could call this decorator inside sdc_overload_method
|
Great progress actually! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
1e-to commentedApr 21, 2020
No description provided.