Sitelet https://web.archive.org/web/20200911154523/https://github.com/IntelPython/sdc/pull/814
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTune integration #814

Open
wants to merge 4 commits into
base: master
from
Open

VTune integration #814

wants to merge 4 commits into from

Conversation

@1e-to
Copy link
Contributor

1e-to commented Apr 21, 2020

No description provided.

etotmeni
@Hardcode84
Copy link
Contributor

Hardcode84 commented Apr 21, 2020

Native part is not included?

ll.add_symbol('__itt_task_begin_new', itt.__itt_task_begin)
ll.add_symbol('__itt_task_end_new', itt.__itt_task_end)

def vtune_profiling_boxing(name_handle):

This comment has been minimized.

@AlexanderKalistratov

AlexanderKalistratov Apr 21, 2020

Collaborator

Why do we need this?

@@ -0,0 +1,40 @@
import ctypes

This comment has been minimized.

@AlexanderKalistratov

AlexanderKalistratov Apr 21, 2020

Collaborator

Let's rename file somehow. Probably, simlpy vtune.py

handle = vt.ctypes_string_handle_create(b"Head\0")

functype_task_begin = ctypes.CFUNCTYPE(None, ctypes.c_void_p, ctypes.c_void_p)
ctypes_task_begin = functype_task_begin(itt.__itt_task_begin)

This comment has been minimized.

@AlexanderKalistratov

AlexanderKalistratov Apr 21, 2020

Collaborator

I believe it should be done in vtune.py, not here. And here just import these functions

etotmeni
@pep8speaks
Copy link

pep8speaks commented Apr 22, 2020 •

Hello @1e-to! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-22 16:23:37 UTC
etotmeni added 2 commits Apr 22, 2020
etotmeni
pep
etotmeni
@@ -2268,6 +2269,7 @@ def hpat_pandas_series_corr_impl(self, other, method='pearson', min_periods=None


@sdc_overload_method(SeriesType, 'head')
@vtune_profiling_overload(name_handle="Series_head")

This comment has been minimized.

@AlexanderKalistratov

AlexanderKalistratov Apr 22, 2020

Collaborator

It should be part of sdc_overload_method decorator. We can extract type name and method name from where.

This comment has been minimized.

@AlexanderKalistratov

AlexanderKalistratov Apr 22, 2020

Collaborator

You actually could call this decorator inside sdc_overload_method

@AlexanderKalistratov
Copy link
Collaborator

AlexanderKalistratov commented Apr 22, 2020

Great progress actually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.