Test failure in `path.join` #131

Jarred-Sumner · 2022-03-19T13:18:04Z

Currently, path.join has a failing test:

These tests are taken from Node, so it likely is a real bug

The code implementing path.join is in this file:

Lines 672 to 678 in 701d6ec

    
           pub fn joinStringBuf(buf: []u8, _parts: anytype, comptime _platform: Platform) []const u8 { 
        
               if (FeatureFlags.use_std_path_join) { 
        
                   var alloc = std.heap.FixedBufferAllocator.init(buf); 
        
                   return std.fs.path.join(&alloc.allocator, _parts) catch unreachable; 
        
               } 
        
               var written: usize = 0;

The code wiring up path.join to JavaScript is here:

bun/src/javascript/jsc/node/types.zig

Lines 2201 to 2215 in 07379ec

    
           pub fn join( 
        
               globalThis: *JSC.JSGlobalObject, 
        
               isWindows: bool, 
        
               args_ptr: [*]JSC.JSValue, 
        
               args_len: u16, 
        
           ) callconv(.C) JSC.JSValue { 
        
               if (comptime is_bindgen) return JSC.JSValue.jsUndefined(); 
        
               if (args_len == 0) return JSC.ZigString.init("").toValue(globalThis); 
        
               var stack_fallback_allocator = std.heap.stackFallback( 
        
                   (32 * @sizeOf(string)), 
        
                   heap_allocator, 
        
               ); 
        
               var allocator = stack_fallback_allocator.get(); 
        
               var arena = std.heap.ArenaAllocator.init(heap_allocator);

The text was updated successfully, but these errors were encountered:

Jarred-Sumner added bug good first issue labels Mar 19, 2022

Test failure in path.join #131

Test failure in path.join #131

Comments

Jarred-Sumner commented Mar 19, 2022

Test failure in `path.join` #131

Test failure in `path.join` #131