Sitelet https://web.archive.org/web/20220516101359/https://github.com/OpenRCT2/OpenRCT2/issues/16867
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor window_editor_object_selection_select_object to return a message #16867

Open
duncanspumpkin opened this issue Mar 24, 2022 · 2 comments
Open

Refactor window_editor_object_selection_select_object to return a message #16867

duncanspumpkin opened this issue Mar 24, 2022 · 2 comments
Labels
good first issue refactor

Comments

@duncanspumpkin
Copy link
Contributor

@duncanspumpkin duncanspumpkin commented Mar 24, 2022

window_editor_object_selection_select_object currently returns its success through a bool and also the global gGameCommandErrorText. It should be refactored to return a GameAction::Result to remove the use of the global.
@duncanspumpkin duncanspumpkin added refactor good first issue labels Mar 24, 2022
@Nekoral
Copy link

@Nekoral Nekoral commented Mar 29, 2022

Could i try this as a first issue ?

@Broxzier
Copy link
Member

@Broxzier Broxzier commented Mar 29, 2022

Sure, go ahead! If you have any questions about the code, you can ask for help either here or on Discord.

linkli-99 added a commit to linkli-99/OpenRCT2 that referenced this issue Apr 22, 2022
@linkli-99
Fix OpenRCT2#16867 Refactor window_editor_object_selection_object to …
1bf6a38 
…return GameActions::Result. Return default with GameActions::Status::OK if it's true, otherwise return object with GameActions::Status::Unknown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duncanspumpkin @Broxzier @Nekoral