[platform-server] SSR for Standalone Component: bootstrapApplication have memory leaks #46473

hiepxanh · 2022-06-23T10:05:02Z

Which @angular/* package(s) are the source of the bug?

platform-server

Is this a regression?

No

Description

ngModule version

I clone the Angular Universal repo version from angular:

checkout master then: pnpm install
pnpm dev:ssr to serve
nodemon --inspect=localhost:9236 dist/server/main.js to inspect

Then I start it and make a heap snapshot. it's fine.
Open dev tools for Node.js to inspect, Go to memory tab, search module keyword

first-time load home page:

load home page at second time:

load home page at 20th times:

everything is fine and no leak. NgModule only have 2 instance

Standalone version

I upgrade the universal version of the standalone component, I'm going to make this on the universal repo, but first, it has a memory leak.

checkout master then: pnpm install
pnpm dev:ssr to serve
nodemon --inspect=localhost:9236 dist/server/main.js to inspect

go home page and f5 for 6 times:

go home page and f5 for more 5 times:

we get too many modules that are not clear and the heap memory goes "To infinity and beyond".
The ApplicationModule goes to x6 on 6 load pages, and x11 if you have 11 load pages.

Please provide a link to a minimal reproduction of the bug

https://github.com/hiepxanh/universal-test

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run `ng version`)

Angular CLI: 14.0.2
Node: 16.13.1
Package Manager: pnpm 7.1.5
OS: win32 x64

Angular: 14.0.3
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, platform-server
... router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1400.2
@angular-devkit/build-angular   14.0.2
@angular-devkit/core            14.0.2
@angular-devkit/schematics      14.0.2
@angular/cli                    14.0.2
@nguniversal/builders           14.0.1
@nguniversal/common             14.0.1
@nguniversal/express-engine     14.0.1
@schematics/angular             14.0.2
rxjs                            7.5.5
typescript                      4.7.4

Anything else?

I'm running the standalone SSR version in my production version. Current work around is restart the server :D

The text was updated successfully, but these errors were encountered:

hiepxanh · 2022-06-23T10:15:19Z

in my production app, it goes really bad, it takes 1 day only to eat my 1 GB ram.

what is the best solution to config, or is it a bug?

hiepxanh · 2022-06-23T10:17:23Z

I only make this modification on express engine
add appId for render options
change renderModule to renderApplication

alan-agius4 · 2022-06-23T14:03:38Z

in my production app, it goes really bad, it takes 1 day only to eat my 1 GB ram.

Side note: this API is still experimental and should not be used in production.

hiepxanh · 2022-06-23T15:59:43Z

sorry, I was tempted. It just too smooth. I used jsdom too, but it event eat more ram than this one.

alxhub · 2022-06-23T23:19:04Z

I believe you're right about the leak. Digging into this just a little, it appears that @angular/platform-server's _render is relying on destroying the platform to destroy the application, and the platform seems to rely on registration of bootstrapped NgModules, so indeed this might not be correctly destroying the rendered application.

hiepxanh · 2022-06-23T23:28:02Z

Yes, I do, I also put a log while testing but do not see that log trigger on ngOnDestroy of appComponent

This commit updates the `ApplicationRef` logic to trigger the destroy operation when an underlying platform is destroyed. This is needed to make sure all teardown processing is completed correctly to avoid memory leaks. Closes angular#46473.

AndrewKushnir · 2022-06-25T02:34:51Z

@hiepxanh I've created a PR with a proposed fix, which ensures that the ApplicationRef.destroy is called (and subsequently clears references) when a platform is destroyed. I'd like to ask if you could try using a package from that PR and let us know if the memory leaks is gone. You can update the package.json in your app like this (and run npm i):

  "@angular/core": "https://output.circle-artifacts.com/output/job/9387cf04-2cb0-47ad-b868-42121b6a011f/artifacts/0/angular/core-pr46497-91c5f1807c.tgz",

Note: this package is for testing purposes only and can not be used in production.

Thank you.

hiepxanh · 2022-06-25T02:36:20Z

@AndrewKushnir yes sir, I'm very exciting, I'll test on this now

hiepxanh · 2022-06-25T02:55:07Z

@AndrewKushnir thank you, sir. There is no sign of the memory leak anymore.

After routing about 100 routes, the memory is still stable. everything is fine. I think I can use it now <3

AndrewKushnir · 2022-06-27T17:15:13Z

@hiepxanh thanks for testing the change! We'll follow our regular dev process (review, testing) and the fix will land in one of the upcoming patch versions (14.0.x). Thank you.

This commit updates the `ApplicationRef` logic to trigger the destroy operation when an underlying platform is destroyed. This is needed to make sure all teardown processing is completed correctly to avoid memory leaks. Closes angular#46473.

#46497) This commit updates the `ApplicationRef` logic to trigger the destroy operation when an underlying platform is destroyed. This is needed to make sure all teardown processing is completed correctly to avoid memory leaks. Closes #46473. PR Close #46497

AndrewKushnir · 2022-06-29T22:36:42Z

@hiepxanh just wanted to let you know that we've released Angular v14.0.4, which contains the memory leak fix. Please try updating to the latest version and let us know if the problem is resolved. Thank you.

hiepxanh · 2022-06-29T22:38:57Z

Thank you that so fast, I'm going to do it now 😍

hiepxanh · 2022-06-29T23:08:08Z

@AndrewKushnir I already test it, and I see the result is very good. Thank you for your effor

AndrewKushnir · 2022-06-29T23:31:29Z

@hiepxanh great, thanks for the update!

hiepxanh mentioned this issue Jun 23, 2022

Application stays in memory even after being destroyed #46408

Closed

hiepxanh changed the title ~~[platform-server] bootstrapApplication have memory leaks, the module generate each time server render~~ [platform-server] SSR for standalone component: bootstrapApplication have memory leaks, the module generate each time server render Jun 23, 2022

hiepxanh changed the title ~~[platform-server] SSR for standalone component: bootstrapApplication have memory leaks, the module generate each time server render~~ [platform-server] SSR for Standalone Component: bootstrapApplication have memory leaks Jun 23, 2022

pkozlowski-opensource added comp: server cross-cutting: standalone labels Jun 23, 2022

ngbot bot added this to the needsTriage milestone Jun 23, 2022

pkozlowski-opensource added the memory leak label Jun 23, 2022

alxhub added P2 bug labels Jun 23, 2022

ngbot bot removed this from the needsTriage milestone Jun 23, 2022

ngbot bot added this to the Backlog milestone Jun 23, 2022

ngbot bot removed this from the needsTriage milestone Jun 23, 2022

ngbot bot added this to the Backlog milestone Jun 23, 2022

AndrewKushnir self-assigned this Jun 24, 2022

AndrewKushnir added the state: has PR label Jun 25, 2022

AndrewKushnir mentioned this issue Jun 25, 2022

fix(core): trigger ApplicationRef.destroy when Platform is destroyed #46497

Closed

3 tasks

dylhunn closed this as completed in 8b6f421 Jun 28, 2022

[platform-server] SSR for Standalone Component: bootstrapApplication have memory leaks #46473

[platform-server] SSR for Standalone Component: bootstrapApplication have memory leaks #46473

hiepxanh commented Jun 23, 2022 •

edited

hiepxanh commented Jun 23, 2022

hiepxanh commented Jun 23, 2022 •

edited

alan-agius4 commented Jun 23, 2022

hiepxanh commented Jun 23, 2022

alxhub commented Jun 23, 2022

hiepxanh commented Jun 23, 2022

AndrewKushnir commented Jun 25, 2022

hiepxanh commented Jun 25, 2022

hiepxanh commented Jun 25, 2022

AndrewKushnir commented Jun 27, 2022

AndrewKushnir commented Jun 29, 2022

hiepxanh commented Jun 29, 2022

hiepxanh commented Jun 29, 2022

AndrewKushnir commented Jun 29, 2022

[platform-server] SSR for Standalone Component: bootstrapApplication have memory leaks #46473

[platform-server] SSR for Standalone Component: bootstrapApplication have memory leaks #46473

Comments

hiepxanh commented Jun 23, 2022 • edited

Which @angular/* package(s) are the source of the bug?

Is this a regression?

Description

ngModule version

Standalone version

Please provide a link to a minimal reproduction of the bug

Please provide the exception or error you saw

Please provide the environment you discovered this bug in (run ng version)

Anything else?

hiepxanh commented Jun 23, 2022

hiepxanh commented Jun 23, 2022 • edited

alan-agius4 commented Jun 23, 2022

hiepxanh commented Jun 23, 2022

alxhub commented Jun 23, 2022

hiepxanh commented Jun 23, 2022

AndrewKushnir commented Jun 25, 2022

hiepxanh commented Jun 25, 2022

hiepxanh commented Jun 25, 2022

AndrewKushnir commented Jun 27, 2022

AndrewKushnir commented Jun 29, 2022

hiepxanh commented Jun 29, 2022

hiepxanh commented Jun 29, 2022

AndrewKushnir commented Jun 29, 2022

hiepxanh commented Jun 23, 2022 •

edited

Please provide the environment you discovered this bug in (run `ng version`)

hiepxanh commented Jun 23, 2022 •

edited