Sitelet https://web.archive.org/web/20220617133742/https://github.com/zulip/zulip/issues/22131
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard shortcut to "Drafts" link tooltip #22131

Open
alya opened this issue May 26, 2022 · 6 comments · May be fixed by #22149
Open

Add keyboard shortcut to "Drafts" link tooltip #22131

alya opened this issue May 26, 2022 · 6 comments · May be fixed by #22149
Labels
area: compose area: keyboard UI good first issue help wanted

Comments

@alya
Copy link
Collaborator

@alya alya commented May 26, 2022

At present, while the left sidebar "Drafts" link tooltip includes the keyboard shortcut, the compose box "Drafts" link tooltip does not. We should fix this.

The compose box "Drafts" tooltip should thus be "Drafts (d)", with the same styling as the compose box x button tooltip:
Screen Shot 2022-05-26 at 4 20 30 PM
@zulipbot
Copy link
Member

@zulipbot zulipbot commented May 26, 2022

Hello @zulip/server-compose members, this issue was labeled with the "area: compose" label, so you may want to check it out!

@alya alya mentioned this issue May 26, 2022
Open
12 tasks
@aparna-bhatt
Copy link
Collaborator

@aparna-bhatt aparna-bhatt commented May 27, 2022

Hey @alya I have solved this issue.But my previous PR Is almost ready to merge so can I contribute in this issue?
Pending PR #22129.
I am uploading the screenshot for you to see the changes.
Screenshot from 2022-05-27 15-46-59

@garg3133
Copy link
Member

@garg3133 garg3133 commented May 28, 2022

Sure @aparna-bhatt, you can go ahead and open a PR for this issue.

@aparna-bhatt
Copy link
Collaborator

@aparna-bhatt aparna-bhatt commented May 28, 2022

OK @garg3133 thanks!

@aparna-bhatt aparna-bhatt mentioned this issue May 28, 2022
Closed
12 tasks
@aparna-bhatt aparna-bhatt linked a pull request May 28, 2022 that will close this issue
Open
12 tasks
@aparna-bhatt
Copy link
Collaborator

@aparna-bhatt aparna-bhatt commented May 28, 2022

@garg3133 I have made the PR can you review it?

@aparna-bhatt
Copy link
Collaborator

@aparna-bhatt aparna-bhatt commented Jun 3, 2022

Hey @alya can you review this PR.
Thanks!

aparna-bhatt pushed a commit to aparna-bhatt/zulip that referenced this issue Jun 5, 2022
added: keyboard shortuct to drafts link tooltip.Fixes zulip#22131.
e456350
aparna-bhatt pushed a commit to aparna-bhatt/zulip that referenced this issue Jun 5, 2022
added: keyboard shortuct to drafts link tooltip.Fixes zulip#22131
95a90c1
aparna-bhatt pushed a commit to aparna-bhatt/zulip that referenced this issue Jun 8, 2022
compose: Add keyboard shortuct tooltip to Drafts link. Fixes zulip#22131
9d1f6d5 
.
aparna-bhatt pushed a commit to aparna-bhatt/zulip that referenced this issue Jun 8, 2022
compose: Add keyboard shortuct tooltip to Drafts link. Fixes zulip#22131
3c11fe1 
.
aparna-bhatt pushed a commit to aparna-bhatt/zulip that referenced this issue Jun 8, 2022
compose: Add keyboard shortcut tooltip to "Drafts" link. Fixes: zulip…
260e482 
…#22131

compose: Add keyboard shortuct tooltip to Drafts link. Fixes zulip#22131.

compose: Add keyboard shortuct tooltip to Drafts link. Fixes zulip#22131.
aparna-bhatt pushed a commit to aparna-bhatt/zulip that referenced this issue Jun 8, 2022
compose: Add keyboard shortuct tooltip to Drafts link.
7bd6b5a 
Fixes: zulip#22131
aparna-bhatt pushed a commit to aparna-bhatt/zulip that referenced this issue Jun 9, 2022
compose: Add keyboard shortuct tooltip to Drafts link.
2da4f33 
Fixes: zulip#22131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: compose area: keyboard UI good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added:keyboard shortcut to Drafts link tooltip aparna-bhatt/zulip
4 participants
@alya @zulipbot @garg3133 @aparna-bhatt