New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging: Simplify and adjust request logging configuration #4961
Comments
|
There's already #4956 to address the log level portion of this issue. |
|
LGTM, though it should get some more actionable items IMO :) |
|
Hello |
|
Hello, I am interested in doing my first contribution to the Thanos project and I think this issue may be a good one to start! I have a good knowledge on Thanos as an user and I still need to study the code and configure the dev environment... so it may take some time |
|
Hey @B0go, sorry for the late reply! Please go ahead, feel free to take your time to familiarize yourself with the code, and don't hesitate to ask if something's not clear |
As seems to stem from the discussion in #4934, request logging implementation and configuration seem to have a couple of confusing features, which might be a bit misleading for the users.
I'll try to summarize some of my and @PhilipGough's observations below:
log.level=debugis used. I think normal user expectation would be to set the level and see the logs being logged at that level, without the need to setlog.level=debug.The text was updated successfully, but these errors were encountered: