Sitelet https://web.archive.org/web/20220601110331/https://github.com/github/vscode-codeql/issues/1373
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken build on Node v18 #1373

Open
elenatanasoiu opened this issue Jun 1, 2022 · 0 comments
Open

Broken build on Node v18 #1373

elenatanasoiu opened this issue Jun 1, 2022 · 0 comments
Labels
bug good first issue VSCode

Comments

@elenatanasoiu
Copy link

@elenatanasoiu elenatanasoiu commented Jun 1, 2022 •

Description

Building the extension via npm run build breaks on Node v18, but works fine on previous versions.

Full error output:

$ npm run build

> vscode-codeql@1.6.7 build
> gulp

[09:05:19] Requiring external module ts-node/register
[09:05:20] Using gulpfile ~/projects/vscode-codeql/extensions/ql-vscode/gulpfile.ts
[09:05:20] Starting 'default'...
[09:05:20] Starting 'cleanOutput'...
[09:05:20] Finished 'cleanOutput' after 14 ms
[09:05:20] Starting 'compileTypeScript'...
[09:05:20] Starting 'compileTextMateGrammar'...
[09:05:20] Starting 'compileView'...
[09:05:20] Starting 'copyTestData'...
[09:05:20] Starting 'copyViewCss'...
[09:05:20] Finished 'copyTestData' after 205 ms
[09:05:20] Finished 'compileTextMateGrammar' after 318 ms
[09:05:20] Finished 'copyViewCss' after 330 ms
webpack compiled successfully
[09:05:31] Finished 'compileView' after 11 s
[09:05:35] 'compileTypeScript' errored after 15 s
[09:05:35] Error: You must provide the URL of lib/mappings.wasm by calling SourceMapConsumer.initialize({ 'lib/mappings.wasm': ... }) before using SourceMapConsumer
    at readWasm (/Users/elenatanasoiu/projects/vscode-codeql/extensions/ql-vscode/node_modules/gulp-typescript/node_modules/source-map/lib/read-wasm.js:8:13)
    at wasm (/Users/elenatanasoiu/projects/vscode-codeql/extensions/ql-vscode/node_modules/gulp-typescript/node_modules/source-map/lib/wasm.js:25:16)
    at /Users/elenatanasoiu/projects/vscode-codeql/extensions/ql-vscode/node_modules/gulp-typescript/node_modules/source-map/lib/source-map-consumer.js:264:14
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
[09:05:35] 'default' errored after 15 s

To reproduce

cd extensions/ql-vscode
nvm install 18
nvm use 18
npm install
npm run build

Expected behavior
The build command should complete without errors.

Additional context
This passes in codespaces as a codespace currently defaults to v16. Discovered while working on #1369

@elenatanasoiu elenatanasoiu added the bug label Jun 1, 2022
@github-actions github-actions bot added the VSCode label Jun 1, 2022
@elenatanasoiu elenatanasoiu added the good first issue label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue VSCode
Projects
None yet
Development

No branches or pull requests

1 participant