Sitelet https://web.archive.org/web/20220602174049/https://github.com/zulip/zulip/pull/22019
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move avatar border outside the image in full profile #22019

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aadiljaleel
Copy link
Collaborator

@aadiljaleel aadiljaleel commented May 7, 2022

Fixes: #21265

move avatar border outside the image in full profile. Instead of using the border which overlap / overflow over the background content, I used outline.

Fixes: #21265

Screenshots and screen captures:

original
original

fixed
fixed

Self-review checklist

  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot zulipbot added size: XS area: popovers bug good first issue labels May 7, 2022
@aadiljaleel
Copy link
Collaborator Author

@aadiljaleel aadiljaleel commented May 7, 2022

@alya can someone review this please?

@aadiljaleel
Copy link
Collaborator Author

@aadiljaleel aadiljaleel commented May 17, 2022

@timabbott can someone review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: popovers bug good first issue size: XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants