Sitelet https://web.archive.org/web/20220526194105im_/https://github.com/matplotlib/matplotlib/pull/23133
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make module deprecation messages consistent #23133

Merged
merged 1 commit into from May 25, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented May 25, 2022

PR Summary

The default message already says more than enough over the manually created one, e.g.,

The module matplotlib.afm is deprecated since 3.6.

vs.

The matplotlib.blocking_input module was deprecated in Matplotlib 3.5 and will be removed two minor releases later.

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

The default message already says more than enough over the manually
created one.
@QuLogic QuLogic added this to the v3.6.0 milestone May 25, 2022
@timhoffm timhoffm merged commit ccf96cd into matplotlib:main May 25, 2022
32 checks passed
@QuLogic QuLogic deleted the module-deprecations branch May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants