Sitelet https://web.archive.org/web/20220524230718/https://github.com/angular/angular/pull/46037
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devtools): Create tooling to support browser specific styles for chrome and firefox #46037

Conversation

MariusTilvanDev
Copy link
Contributor

@MariusTilvanDev MariusTilvanDev commented May 18, 2022

Create browser specific styles for chrome and firefox

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

There is no specific style based on browser Chrome/Firefox

Issue Number: #45889

What is the new behavior?

There are browser specific styles for chrome and firefox.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from twerske May 18, 2022
@MariusTilvanDev
Copy link
Contributor Author

@MariusTilvanDev MariusTilvanDev commented May 18, 2022

@AleksanderBodurri I created this new PR.

Copy link
Member

@AleksanderBodurri AleksanderBodurri left a comment

LGTM. It looks like the 2 commits have the same commit message. Could we rebase/fixup them up into 1 commit?

Reference
https://git-scm.com/docs/git-rebase#_interactive_mode

Create browser specific styles for chrome and firefox
@MariusTilvanDev MariusTilvanDev force-pushed the create-browser-specific-styles-chrome-firefox branch from 869a25d to 54939ca Compare May 19, 2022
@MariusTilvanDev
Copy link
Contributor Author

@MariusTilvanDev MariusTilvanDev commented May 19, 2022

LGTM. It looks like the 2 commits have the same commit message. Could we rebase/fixup them up into 1 commit?

Reference https://git-scm.com/docs/git-rebase#_interactive_mode

Done

@AleksanderBodurri AleksanderBodurri added action: merge target: minor labels May 19, 2022
@AleksanderBodurri AleksanderBodurri changed the title feat(devtools): Create browser specific styles for chrome and firefox feat(devtools): Create tooling to support browser specific styles for chrome and firefox May 19, 2022
@alxhub
Copy link
Contributor

@alxhub alxhub commented May 23, 2022

This PR was merged into the repository by commit c3205d0.

@MariusTilvanDev MariusTilvanDev deleted the create-browser-specific-styles-chrome-firefox branch May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge comp: devtools target: minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants