Update rq.py#223
Closed
allfro wants to merge 1 commit into
Closed
Conversation
Fixes return type inconsistency with the `pack_value` for class `Object`. When using an `Object` field embedded in a request `pack_value` croaks because it calls to_binary which returns a byte buffer instead of a 3-value tuple. This fix addresses the issue.
| def pack_value(self, val): | ||
| return self.type.pack_value(val) | ||
| val = self.type.pack_value(val) | ||
| return val, len(val), None |
Collaborator
There was a problem hiding this comment.
Maybe it's better to fix pack_value implementation at line 1074 and below? Also line 911 is interesting. For this line 607 it looks reasonable to delegate this to underlying function call. So I suggest to fix the underlying functions instead. What do you think?
Merged
Collaborator
|
Fixed in another PR. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes return type inconsistency with the
pack_valuefor classObject.When using an
Objectfield embedded in a requestpack_valuecroaks because it calls to_binary which returns a byte buffer instead of a3-value tuple. This fix addresses the issue.