base64 encode data payload in event_record for lambda functions #5351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62418a4 to
e2a84e3
Compare
|
hmm, preflight is failing due to unit test |
|
I tried re-running the build and it failed in the same way. Not totally sure what the issue is. Can you try pulling and rebasing off master? |
whummer
reviewed
Jan 28, 2022
a0d5fbe to
bea97ec
Compare
|
Thanks for updating the PR @KOConchobhair ! 👍 Looks like we still have a small issue in our tests in the CI pipeline - did you have a chance to look into it? Also requesting help from @SwatsonCodes who can help us review what should be the right behavior here.. Thanks! |
|
Hi @KOConchobhair! I'll close this PR for now. Please feel free to create a new PR or issue in case you're still experiencing any issues. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5350.
I'm not familar enough with the codebase to fix this somewhere higher up the chain without potentially breaking other things since it does not appear this functionality is currently being unit tested. I looked at some existing tests but couldn't figure out the best way to test this sort of thing, i.e. a kinesis stream with .net lambda event source mapping. Didn't seem appropriate to just add it to the existing test_kinesis.py