Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly remove "awaiting change" PR label after all reviewers approved. #71
Comments
Verified
When there are multiple reviewers who requested changes, the "awaiting change" label should only be removed after all reviewers approved the new changes. Closes python#71
|
So I debated with myself about this when I initially implemented the feature. The problem is that core devs are not the most responsive folks in the world due to lack of time. So if two or more people review and just one of them delays, it would then delay the whole PR. This also deviates somewhat from the old workflow where you didn't have to wait for other core devs to sign off if the reviewer clearing the PR thought the other comments were appropriately taken care of. IOW I don't know if this is a good or bad thing to do, hence why I went with the one that was the easiest to code up. |
|
I don't personally have strong preference. The simpler workflow is fine too :) |
When there are multiple reviewers who requested changes, the "awaiting change" label should only be removed after all reviewers approved the new changes.
As brought up by @1st1 in python/cpython#4314: