Sitelet https://web.archive.org/web/20220502093319/https://github.com/github/codeql-action/pull/1024
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autobuild: add working-directory input #1024

Merged
merged 2 commits into from Apr 8, 2022
Merged

autobuild: add working-directory input #1024

merged 2 commits into from Apr 8, 2022

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Apr 7, 2022 •
edited

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@cklin cklin force-pushed the autobuild-working-dir branch 2 times, most recently from 7be1601 to fff62ed Compare Apr 7, 2022
@cklin cklin marked this pull request as ready for review Apr 7, 2022
@cklin cklin requested a review from as a code owner Apr 7, 2022
@cklin
Copy link
Author

@cklin cklin commented Apr 7, 2022

@igfoo Do you have any thoughts on how we should test this functionality?

aeisenberg
aeisenberg reviewed Apr 7, 2022
View changes
src/autobuild-action.ts Outdated Show resolved Hide resolved
@cklin cklin requested a review from aeisenberg Apr 7, 2022
@aeisenberg
Copy link

@aeisenberg aeisenberg commented Apr 7, 2022

Looks like a spurious failure.

@aeisenberg
Copy link

@aeisenberg aeisenberg commented Apr 7, 2022

Best way to test this would be to generate a small test project that uses the autobuild action. Create a workflow that runs codeql on that project and make sure to specify a working directory input. Perhaps something similar to the checkout_path tests.

@igfoo
Copy link

@igfoo igfoo commented Apr 8, 2022

I've given it a try, and it looks like it works for me; thanks!

@cklin cklin closed this Apr 8, 2022
@cklin cklin reopened this Apr 8, 2022
@cklin cklin force-pushed the autobuild-working-dir branch 2 times, most recently from 384abcf to dd84f73 Compare Apr 8, 2022
aeisenberg
aeisenberg approved these changes Apr 8, 2022
View changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

nice

@cklin cklin force-pushed the autobuild-working-dir branch 3 times, most recently from 9541eae to f6834f6 Compare Apr 8, 2022
@cklin
Copy link
Author

@cklin cklin commented Apr 8, 2022

Finally got PR Check - Autobuild working directory to work:

@cklin cklin merged commit baf90d1 into github:main Apr 8, 2022
254 checks passed
@cklin cklin deleted the autobuild-working-dir branch Apr 8, 2022
@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Merged
6 tasks
@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cklin @aeisenberg @igfoo