Sitelet https://web.archive.org/web/20220402194019/https://github.com/denoland/deno/issues/13640
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL imports should use no-check by default #13640

Open
lucacasonato opened this issue Feb 10, 2022 · 5 comments
Open

REPL imports should use no-check by default #13640

lucacasonato opened this issue Feb 10, 2022 · 5 comments
Labels
cli good first issue help wanted l-rust repl suggestion

Comments

@lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Feb 10, 2022

No description provided.

@lucacasonato lucacasonato added suggestion cli repl labels Feb 10, 2022
@bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Feb 10, 2022

I agree, this should speed up REPL significantly

@bartlomieju bartlomieju added good first issue l-rust help wanted labels Mar 22, 2022
@a-lafrance
Copy link

@a-lafrance a-lafrance commented Mar 24, 2022

I'm interested in giving this change a try if that's alright, although I'm not super familiar with the codebase so I might need some more context about what exactly this change entails. I was poking around the code to try and get more info and I found the no-check flag in the CLI, so I guessed that maybe this change is just setting a different default for that flag for the repl subcommand.

So concretely I guess I have 2 related questions:

  1. Is my understanding correct? I'm under the impression that I'm basically just setting the check flag to either None or Local as a default for repl, so I'd just like to make sure I'm on the right track

  2. If that's not quite the right thought process, I'd really appreciate some guidance to get me on the right track.

Thanks in advance!

@bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Mar 24, 2022

Hi @a-lafrance, thanks for looking into this.

Is my understanding correct? I'm under the impression that I'm basically just setting the check flag to either None or Local as a default for repl, so I'd just like to make sure I'm on the right track

Yes, this is right. In repl_parse in cli/flags.rs set flags.no_check to None and that should be it.

@a-lafrance
Copy link

@a-lafrance a-lafrance commented Mar 25, 2022

great, thanks for the info! I'll try to get a PR up soon

@VishnuJin
Copy link
Contributor

@VishnuJin VishnuJin commented Mar 25, 2022

Yes, this is right. In repl_parse in cli/flags.rs set flags.no_check to None and that should be it.

jfyi @a-lafrance flags.check should be set to CheckFlag::None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli good first issue help wanted l-rust repl suggestion
Projects
None yet
Development

No branches or pull requests

4 participants