Sitelet https://web.archive.org/web/20220707004728/https://github.com/xamarin/xamarin-macios/issues/13622
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It would be nice if CTFont constructor's matrix parameter was "in" instead of "ref" #13622

Open
rolfbjarne opened this issue Dec 22, 2021 · 1 comment
Open

It would be nice if CTFont constructor's matrix parameter was "in" instead of "ref" #13622

rolfbjarne opened this issue Dec 22, 2021 · 1 comment
Labels
enhancement good first issue
Milestone
Future

Comments

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Dec 22, 2021 •
edited

This might be a problem throughout Xamarin.Mac and Monotouch, but CTFont constructor is currently defined as:

public CTFont(CTFontDescriptor descriptor, nfloat size, CTFontOptions options, ref CGAffineTransform matrix);

whereas the native side is:

CTFontRef CTFontCreateWithName ( CFStringRef name, CGFloat size, const CGAffineTransform *matrix );

not being an "in" parameter means I can't pass a temporary object to the constructor, which is a very minor but avoidable PITA, if the native API was bound better.

Source: https://bugzilla.xamarin.com/28/28349/bug.html
@rolfbjarne rolfbjarne added enhancement breaking-change labels Dec 22, 2021
@rolfbjarne rolfbjarne added this to the .NET 6 milestone Dec 22, 2021
@rolfbjarne rolfbjarne mentioned this issue Dec 22, 2021
Closed
44 tasks
@rolfbjarne
Copy link
Member Author

@rolfbjarne rolfbjarne commented Feb 3, 2022

This isn't a breaking change, we'd just have to add an additional overload of the constructor.

@rolfbjarne rolfbjarne removed the breaking-change label Feb 3, 2022
@rolfbjarne rolfbjarne removed this from the .NET 6 milestone Feb 3, 2022
@rolfbjarne rolfbjarne added this to the Future milestone Feb 3, 2022
@rolfbjarne rolfbjarne added the good first issue label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@rolfbjarne