Sitelet https://web.archive.org/web/20220403202042/https://github.com/grafana/mimir/issues/800
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: replace model.Metric with labels.Labels in MetricsForLabelMatchers() #800

Open
pracucci opened this issue Jan 19, 2022 · 0 comments
Open

Chore: replace model.Metric with labels.Labels in MetricsForLabelMatchers() #800

pracucci opened this issue Jan 19, 2022 · 0 comments
Labels
chore good first issue

Comments

@pracucci
Copy link
Collaborator

@pracucci pracucci commented Jan 19, 2022

In #790 we've removed metric.Metric in favour of model.Metric. The next step could be just moving to labels.Labels in MetricsForLabelMatchers() instead of model.Metric. This could also save some memory allocations due to type casting.
@pracucci pracucci added chore good first issue labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pracucci