Sitelet https://web.archive.org/web/20220403170409/https://github.com/lichess-org/lila/issues/10180
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn, Coordinates without time for kids #10180

Open
benediktwerner opened this issue Nov 28, 2021 Discussed in #10177 · 19 comments · May be fixed by #10705
Open

Learn, Coordinates without time for kids #10180

benediktwerner opened this issue Nov 28, 2021 Discussed in #10177 · 19 comments · May be fixed by #10705
Labels
good first issue

Comments

@benediktwerner
Copy link
Collaborator

@benediktwerner benediktwerner commented Nov 28, 2021

Discussed in #10177

Originally posted by drdoom November 27, 2021
For kids and grown kids that want to learn coordinate system, 30 seconds is a very low time, adding a timeless option will allow them to learn at their own pace.

@benediktwerner benediktwerner added good first issue no scala labels Nov 28, 2021
@rogersheu
Copy link

@rogersheu rogersheu commented Nov 30, 2021

More suggestions:

  • Other time limits, perhaps in a drop-down menu, including the current 30 second mode, 1 minute, and unlimited.

  • Toggle on/off pieces (or at least make them faded).

  • Toggle on/off letters and numbers at the side of the board.

  • Toggle on/off coordinates for each square.

Since part of this exercise can be mental muscle memory, it'd be great to provide various levels of assistance before throwing new players straight into a 30 second timed challenge mode.

@bigsee
Copy link
Contributor

@bigsee bigsee commented Dec 5, 2021

I'd be interested in taking a look at this (and the cool ideas from @rogersheu). It would be nice to break down into the smallest possible deployable increments.

To implement the initial feature request, I would envisage a simple toggle for 'Practice mode' underneath the timer.

  1. The score and timer would be blank/greyed out and not change when the 'practice mode is toggled on'
  2. The 'start training' button would be greyed out / disabled
  3. The current mode would run as long as they want to play until 'practice mode' is toggled off

@benediktwerner Does that approach sound reasonable?

@benediktwerner
Copy link
Collaborator Author

@benediktwerner benediktwerner commented Dec 6, 2021

Seems reasonable. Probably makes more sense to just not show the timer at all though.

@bigsee
Copy link
Contributor

@bigsee bigsee commented Dec 7, 2021 •

Do I understand correctly that one actually does need to use Scala to work on this issue? I initially looked into it on the basis of the no scala tag. I am happy to try and get my head around it but might be worth updating for future viewers / potential contributors.

@maxrosenb
Copy link
Contributor

@maxrosenb maxrosenb commented Dec 7, 2021

@bigsee yes, when I took a stab at doing this myself I came to the same conclusion, more scala code is needed for this feature.

@benediktwerner
Copy link
Collaborator Author

@benediktwerner benediktwerner commented Dec 9, 2021

Depends on how exactly you do it but likely some amount of changes to scala code will indeed be needed. Most likely only to views using scalatags though which is pretty much just HTML.

@FlyingndCoding
Copy link

@FlyingndCoding FlyingndCoding commented Dec 24, 2021

Discussed in #10177

Originally posted by drdoom November 27, 2021 For kids and grown kids that want to learn coordinate system, 30 seconds is a very low time, adding a timeless option will allow them to learn at their own pace.

I guess so custom time feature shall be added in coordinate system

@johnboltum
Copy link

@johnboltum johnboltum commented Jan 12, 2022

@bigsee @maxrosenb I'd be interested in working on this with you guys. I haven't contributed to Lichess before and it looks like I'd have to familiarize myself some with Scala, but this seems like it might be an alright place to start. Would either of you want to discuss over discord?

@bigsee
Copy link
Contributor

@bigsee bigsee commented Jan 12, 2022 •

@johnboltum Sure - I'd be up for that. Short on time at the moment but still keen to contribute in any way I can.

@Bitsy-Chuck
Copy link

@Bitsy-Chuck Bitsy-Chuck commented Jan 18, 2022

@johnboltum @bigsee Would love to contribute to this issue. If possible, we can divide the work :p

@DakshCodess
Copy link

@DakshCodess DakshCodess commented Jan 18, 2022

@johnboltum
Copy link

@johnboltum johnboltum commented Jan 27, 2022

@Bitsy-Chuck @bigsee @maxrosenb Hop on this discord server and we can continue discussing some more and get this done, https://discord.gg/WQVJtVfB

@bigsee
Copy link
Contributor

@bigsee bigsee commented Jan 27, 2022

Joining now...

@schlawg
Copy link
Contributor

@schlawg schlawg commented Mar 22, 2022

Are you guys still working this?

@bigsee
Copy link
Contributor

@bigsee bigsee commented Mar 23, 2022

@Virinas-code
Copy link
Contributor

@Virinas-code Virinas-code commented Mar 23, 2022

I'm working on this.

@Virinas-code
Copy link
Contributor

@Virinas-code Virinas-code commented Mar 27, 2022 •

Benedikt Werner said on 9 Dec 2021

Depends on how exactly you do it but likely some amount of changes to scala code will indeed be needed. Most likely only to views using scalatags though which is pretty much just HTML.

All the view is in the view.ts file. You need Scala only for translations, if you add one (probably not).

@brollin
Copy link
Collaborator

@brollin brollin commented Mar 27, 2022

When he wrote that it was true, but yeah now you mainly just need Typescript to update the coordinate trainer.

@Virinas-code
Copy link
Contributor

@Virinas-code Virinas-code commented Mar 27, 2022

OK, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.