Code Editor basic support for: undo, redo, find, replace #3129
Conversation
e17f0c9 to
417d185
Compare
| } | ||
| .CodeMirror-search-label{ |
There was a problem hiding this comment.
Please remove this empty CSS key/body.
|
|
||
| } | ||
| .CodeMirror-dialog { |
There was a problem hiding this comment.
Could you please check the styling with dark themes, it's a bit odd. Also, OneDark has dark font color on dark background.
There was a problem hiding this comment.
Yes the control was essentially un-themed. Would you prefer legibility is working for both, or to actually flip the theme based on marktext?
There was a problem hiding this comment.
Flipping the theme would be great. I think we use two different themes based whether MarkTexts theme is light or darkish. Maybe we can use CSS selectors to differentiate colors.
There was a problem hiding this comment.
Yeah I assumed CSS light/dark overall would be the way to go. Will update.
| import 'codemirror/addon/search/searchcursor' | ||
| import 'codemirror/addon/dialog/dialog' | ||
| import 'codemirror/addon/search/search' | ||
| import 'codemirror/addon/search/jump-to-line' |
There was a problem hiding this comment.
Is this needed for search or only for the Alt+G shortcut? Please remove the dependency if it's not necessary for seach as it may conflict with other functions (later).
There was a problem hiding this comment.
Only jump-to-line is for alt+g, the rest is required for search. I expect in the long term that the code editor will get more 'native' search removing the dialog need. As far as I know the addons should not cause any code conflict as they are siloed into their own class.
There was a problem hiding this comment.
Core problem that the feature is undocumented and it doesn't for for preview mode.
There was a problem hiding this comment.
Sure, that was largely why I was leaving it undocumented too, was it only worked in the code editor. To confirm you just want jump-to-line removed correct?
| @@ -993,13 +993,13 @@ export default { | |||
| }, | |||
|
|
|||
| handleUndo () { | |||
| if (this.editor) { | |||
| if (this.editor && this.sourceCode === false) { | |||
There was a problem hiding this comment.
You can simplify this.sourceCode === false to !this.sourceCode
| this.editor.undo() | ||
| } | ||
| }, | ||
|
|
||
| handleRedo () { | ||
| if (this.editor) { | ||
| if (this.editor && this.sourceCode === false) { |
There was a problem hiding this comment.
You can simplify this.sourceCode === false to !this.sourceCode
| @@ -1077,6 +1077,7 @@ export default { | |||
| }, | |||
|
|
|||
| handleFindAction (action) { | |||
| if (this.sourceCode) { return } | |||
There was a problem hiding this comment.
Please add a new line to the body (preferred) or remove brackets around return.
| }, | ||
|
|
||
| docClick () { | ||
| if (this.editor && this.sourceCode) { this.editor.execCommand('clearSearch') } |
There was a problem hiding this comment.
Please add the body in a new line.
| @@ -245,6 +261,49 @@ export default { | |||
| this.tabId = null // invalidate tab id | |||
| } | |||
| }, | |||
| handleUndo () { | |||
There was a problem hiding this comment.
Please keep spacing (new lines) between methods. You could group e.g. undo/redo etc if you like.
Description
Adds some of the features requested from #2188
This is a bit of a quick hack together so not properly implemented to use the marktext search box, instead use the codeMirror one with some styling. This also adds an undocumented, keybind of alt+g to go to jump to line number. Note if you bind something to alt+g in marktext then this will not fire.