New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding VBS feature names to Get-ComputerInfo #16415
Conversation
Adding new Virtualization-Based Security (VBS) feature names to the Get-ComputerInfo cmdlet. This commit addresses issue PowerShell#16357
|
It would be great to update tests. |
The update to this test addresses issue PowerShell#16357 and updates PR PowerShell#16415. Now, there will be a 1:1 mapping of VBS feature names to be tested alongside the newly implemented feature names in `GetComputerInfoCommand.cs`. Thank you for the suggestion, @iSazonov.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
I think the test is broken because it doesn't catch the issue. The test checks seem only valid return values but it doesn't check absence of values. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
The test is marked as Pending and I'm not sure what values will show up in CI/CD instances
|
@mattifestation Thanks for your contribution! |
|
Handy links: |

Adding new Virtualization-Based Security (VBS) feature names to the Get-ComputerInfo cmdlet. This commit addresses issue #16357
PR Summary
This PR adds supported Virtualization-Based Security (VBS) feature names to the Get-ComputerInfo cmdlet. This PR addresses issue #16357.
Thank you for your consideration.
PR Context
Upon merging this PR, users of Windows Defender Application Control (WDAC) will benefit more greatly from Get-ComputerInfo in that it will present all available VBS features in a human-readable fashion, as Get-ComputerInfo intended. The feature names added in this PR will also offer parity with the feature names presented in the
msinfo32.exeUI.Note: this change would also ideally need to be backported to Windows PowerShell.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).