Sitelet https://web.archive.org/web/20220228111453/https://github.com/marktext/marktext/pull/900
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list indentation settings #900

Merged
merged 1 commit into from Apr 10, 2019
Merged

add list indentation settings #900

merged 1 commit into from Apr 10, 2019

Conversation

@fxha
Copy link
Contributor

@fxha fxha commented Apr 9, 2019

Q A
New feature? yes
Fixed tickets #887
License MIT

Description

  • added list indentation settings
  • fixed settings update process
  • update settings document text too

fixes #887

@fxha fxha requested a review from Jocs Apr 9, 2019
@Jocs
Copy link
Member

@Jocs Jocs commented Apr 10, 2019

@fxha I pull down you branch and run locally, write markdown bellow:

- foo
- bar

it still only one space after - opened by VS Code when I save as markdown file. why not be 4 space after -?

@fxha
Copy link
Contributor Author

@fxha fxha commented Apr 10, 2019

it still only one space after - opened by VS Code when I save as markdown file. why not be 4 space after -?

It's called list indentation. Please see here for examples.

@Jocs
Copy link
Member

@Jocs Jocs commented Apr 10, 2019

Sorry, forgot to say a bit, I have set the listIndentation of the preference to dfm.

@fxha
Copy link
Contributor Author

@fxha fxha commented Apr 10, 2019 •

I don't get your point. Why should there be multiple spaces after - and the text? If you set "listIndentation": "dfm" you get something like this:

- asd
- asd
    - asd <4 spaces before `-`>
        - asd <8 spaces before `-`>
- asd

Right?


  • npm run dev --> ~/.config/Electron/preference.md
  • builded application ---> ~/.config/marktext/preference.md

@Jocs
Copy link
Member

@Jocs Jocs commented Apr 10, 2019

I maybe misunderstand the listIndentation. I consider the result be:

-    asd
-    asd
     -     asd <5 spaces before `-`>
           -     asd <10 spaces before `-`>
-    asd

?

Jocs
Jocs approved these changes Apr 10, 2019
@Jocs Jocs merged commit 1c4ec7c into marktext:master Apr 10, 2019
2 checks passed
@fxha fxha deleted the list-identation branch Apr 10, 2019
@fxha
Copy link
Contributor Author

@fxha fxha commented Apr 10, 2019

No, it just defines the indentation of sub list items/paragraphs.

@fxha
Copy link
Contributor Author

@fxha fxha commented Apr 10, 2019

If you want 4 spaces after the parent bullet maker, you need to set "listIndentation": 4:

- asd
     - asd <5 spaces before `-`>
           - asd <10 spaces before `-`>
- asd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants