C#: Exclude Equals and GetHashCode overrides from model generation.#8626
Merged
michaelnebel merged 4 commits intoApr 4, 2022
Merged
Conversation
086ef5c to
2be2ad4
Compare
tamasvajk
previously requested changes
Apr 1, 2022
tamasvajk
left a comment
Contributor
There was a problem hiding this comment.
Looks good apart from the minor typo.
tamasvajk
reviewed
Apr 1, 2022
hvitved
reviewed
Apr 1, 2022
26bac64 to
a5cccde
Compare
a5cccde to
5cb2bd9
Compare
…o extend it with more methods later.
hvitved
approved these changes
Apr 1, 2022
Contributor
Author
|
The DCA doesn't indicate that there are any performance regressions. |
hvitved
approved these changes
Apr 4, 2022
Contributor
Author
Pr. the discussion on slack in codeql-dist-compare. I loooked that actual workflow execution (and query execution times) and not only the overview page as the uinterpreted queries are not included in the overall analysis time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.