Sitelet https://web.archive.org/web/20220701053304/https://github.com/Moya/Moya/issues/1940
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SwiftPM testing dependencies on release using Rocket. #1940

Open
sunshinejr opened this issue Oct 22, 2019 · 4 comments
Open

Remove SwiftPM testing dependencies on release using Rocket. #1940

sunshinejr opened this issue Oct 22, 2019 · 4 comments
Labels
enhancement good first issue hacktoberfest spm

Comments

@sunshinejr
Copy link
Member

@sunshinejr sunshinejr commented Oct 22, 2019

Currently we use a pretty naive removal of testing dependencies for SwiftPM by setting an environment variable. We should be able to use Rocket and update our Rakefile script to just remove testing dependencies on each release, and keep it in the development process thanks to that.

The idea came from this PR that I saw RxSwiftCommunity/RxOptional#83, which sounds really amazing.

cc @f-meloni I know you wanted to play with Rocket here as well, maybe you would like to try this one out?
@f-meloni
Copy link
Member

@f-meloni f-meloni commented Oct 22, 2019

Yes, that would allow me to play also a little bit with the Danger config as well.
At the moment I'm working on replacing Marathon on Danger-swift but as soon as I find a little bit of time I will have a look at this :)

@f-meloni
Copy link
Member

@f-meloni f-meloni commented Jan 1, 2020

I was having a look at this issue, but from what I see in the Package.swift there are actually no dev dependencies or tests that Rocket should remove

https://github.com/Moya/Moya/blob/master/Package.swift

@sunshinejr
Copy link
Member Author

@sunshinejr sunshinejr commented Jan 2, 2020

@f-meloni see the Package.swift in the development branch :D

@f-meloni
Copy link
Member

@f-meloni f-meloni commented Jan 2, 2020

Ok lol
Makes a lot of sense :D
Thank you 💯
You should see my draft PR soon then :P

@f-meloni f-meloni mentioned this issue Jan 4, 2020
Merged
@Robuske Robuske mentioned this issue Mar 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue hacktoberfest spm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunshinejr @f-meloni