Sitelet https://web.archive.org/web/20220401233344/https://github.com/flutter/flutter/pull/100693
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to ThemeExtension example #100693

Merged
merged 3 commits into from Mar 30, 2022
Merged

Minor improvements to ThemeExtension example #100693

merged 3 commits into from Mar 30, 2022
+20 −20

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Mar 24, 2022

Noticed these small errors while writing more examples.

#31522

@guidezpl guidezpl requested a review from darrenaustin Mar 24, 2022
@goderbauer goderbauer added framework f: material design labels Mar 24, 2022
clocksmith
clocksmith reviewed Mar 30, 2022
View changes
examples/api/lib/material/theme/theme_extension.1.dart Outdated
@@ -18,7 +18,7 @@ class MyColors extends ThemeExtension<MyColors> {
final Color? red;

@override
MyColors copyWith({Color? red, Color? blue}) {
MyColors copyWith({Color? blue, Color? red}) {
Copy link
Contributor

@clocksmith clocksmith Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would firstColor and secondColor be more generic for this example?

Copy link
Member Author

@guidezpl guidezpl Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was meant to represent semantic colors, but you're right, I can change to something more meaningful like "caution" and "danger"

@guidezpl guidezpl merged commit 2d89866 into flutter:master Mar 30, 2022
27 of 28 checks passed
@guidezpl guidezpl deleted the small-fixes branch Mar 30, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Mar 31, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
c17bdbd 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Mar 31, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
f1615df 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Mar 31, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
ce2b073 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Mar 31, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
b4b5588 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
24817ef 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
6b1f3a5 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
e535032 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
63d9197 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
ded9ec2 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
414b4d7 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
a2a9afd 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
054f99c 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
46ce857 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
40b1100 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
5eec983 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
1d98a98 
…tter#100693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
ac4aef6 
…tter#100693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
f190bc6 
…tter#100693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
f7720f2 
…tter#100693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
542bfe9 
…tter#100693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 1, 2022
@engine-flutter-autoroll
2d89866c5 Minor improvements to ThemeExtension example (flutter/flu…
f2502f3 
…tter#100693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clocksmith clocksmith

@darrenaustin darrenaustin

Assignees
No one assigned
Labels
f: material design framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guidezpl @clocksmith @goderbauer