Sitelet https://web.archive.org/web/20220411050959/https://github.com/verdaccio/verdaccio/issues/2854
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a folder for assets referenced in package's README.md #2854

Open
juanpicado opened this issue Jan 3, 2022 Discussed in #2853 · 0 comments
Open

provide a folder for assets referenced in package's README.md #2854

juanpicado opened this issue Jan 3, 2022 Discussed in #2853 · 0 comments

Comments

@juanpicado
Copy link
Member

@juanpicado juanpicado commented Jan 3, 2022 •

Discussed in #2853

Originally posted by microrache January 3, 2022
It would be cool to have something like a "public"- or "assets"-folder which is exposed by Verdaccio's web server. This folder then could be mounted as a Docker Volume, where e.g. screenshots and other assets are stored. These assets then could be referenced in the package's README.md like
![See in action](/-/static/screenshots/my-screenshot.png)

It already worked in the described way in Verdaccio 4.x by mounting a Docker Volume to:
/opt/verdaccio/node_modules/@verdaccio/ui-theme/static/screenshots

But since v5 there seems to be no static-folder or anything comprehensible, which can be used for the desired purpose. Is it possible to re-implement such a directory?

What to consider

  • This might be a plugin (middleware)
  • Docker needs to be aware of this assets folder
  • Any security implication? 🤔
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant