Sitelet https://web.archive.org/web/20220331064826/https://github.com/PowerShell/PowerShell/pull/16578
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all references to cmake for the builds in this repo #16578

Merged
merged 2 commits into from Jan 26, 2022
Merged

Remove all references to cmake for the builds in this repo #16578

merged 2 commits into from Jan 26, 2022

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Dec 8, 2021 •
edited

PR Summary

Remove all references to cmake for the builds in this repo

PR Context

Consider backporting this so we don't install build tools we don't need.

PR Checklist

@TravisEz13 TravisEz13 marked this pull request as ready for review Dec 8, 2021
adityapatwardhan
adityapatwardhan requested changes Dec 8, 2021
View changes
test/perf/benchmarks/assets/compiler.test.ps1
@@ -1149,7 +1149,7 @@ function Start-PSBootstrap {
$Deps = @()
if ($environment.IsLinux -and $environment.IsUbuntu) {
# Build tools
$Deps += "curl", "g++", "cmake", "make"
$Deps += "curl", "g++", "make"
Copy link
Member

@adityapatwardhan adityapatwardhan Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need g++ and make?

Copy link
Member

@daxian-dbw daxian-dbw Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is a test file, so the content in it doesn't matter.

test/perf/benchmarks/assets/compiler.test.ps1
@@ -1179,7 +1179,7 @@ function Start-PSBootstrap {
}
} elseif ($environment.IsLinux -and $environment.IsRedHatFamily) {
# Build tools
$Deps += "which", "curl", "gcc-c++", "cmake", "make"
$Deps += "which", "curl", "gcc-c++", "make"
Copy link
Member

@adityapatwardhan adityapatwardhan Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Member

@daxian-dbw daxian-dbw Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. this file is for performance testing.

test/perf/benchmarks/assets/compiler.test.ps1
@@ -1203,7 +1203,7 @@ function Start-PSBootstrap {
}
} elseif ($environment.IsLinux -and $environment.IsSUSEFamily) {
# Build tools
$Deps += "gcc", "cmake", "make"
$Deps += "gcc", "make"
Copy link
Member

@adityapatwardhan adityapatwardhan Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Member

@daxian-dbw daxian-dbw Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto. changes to this file can be reverted.

@msftbot msftbot bot added the Waiting on Author label Dec 8, 2021
@msftbot msftbot bot added the Stale label Dec 24, 2021
@msftbot
Copy link

@msftbot msftbot bot commented Dec 24, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@msftbot msftbot bot closed this Jan 3, 2022
@TravisEz13 TravisEz13 reopened this Jan 25, 2022
@msftbot msftbot bot removed Waiting on Author Stale labels Jan 25, 2022
@pull-request-quantifier
Copy link

@pull-request-quantifier pull-request-quantifier bot commented Jan 25, 2022

This PR has 37 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +10 -27
Percentile : 14.8%

Total files changed: 5

Change summary by file extension:
.psm1 : +4 -8
.md : +2 -4
.ps1 : +4 -6
tools/releaseBuild/Images/microsoft_powershell_alpine3/Dockerfile : +0 -9

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan merged commit 5e005b8 into PowerShell:master Jan 26, 2022
50 checks passed
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging label Jan 26, 2022
@msftbot
Copy link

@msftbot msftbot bot commented Feb 24, 2022

🎉v7.3.0-preview.2 has been released which incorporates this pull request.🎉

Handy links:

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this issue Mar 9, 2022
@TravisEz13 @TravisEz13
Remove all references to cmake for the builds in this repo (PowerSh…
64ff0fc 
…ell#16578)

# Conflicts:
#	build.psm1
#	test/perf/benchmarks/assets/compiler.test.ps1
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this issue Mar 14, 2022
@TravisEz13 @TravisEz13
Remove all references to cmake for the builds in this repo (PowerSh…
7d5fcd0 
…ell#16578)

# Conflicts:
#	build.psm1
#	test/perf/benchmarks/assets/compiler.test.ps1

# Conflicts:
#	docs/building/linux.md
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this issue Mar 15, 2022
@TravisEz13 @TravisEz13
Remove all references to cmake for the builds in this repo (PowerSh…
96bdcfc 
…ell#16578)

# Conflicts:
#	build.psm1
#	test/perf/benchmarks/assets/compiler.test.ps1

# Conflicts:
#	docs/building/linux.md

# Conflicts:
#	build.psm1
@msftbot
Copy link

@msftbot msftbot bot commented Mar 16, 2022

🎉v7.0.9 has been released which incorporates this pull request.🎉

Handy links:

@msftbot
Copy link

@msftbot msftbot bot commented Mar 16, 2022

🎉v7.2.2 has been released which incorporates this pull request.🎉

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapatwardhan adityapatwardhan

@anmenaga anmenaga

@daxian-dbw daxian-dbw

@PaulHigin PaulHigin

Assignees

@adityapatwardhan adityapatwardhan

Labels
BackPort-7.0.x-Approved Backport-7.2.x-Done CL-BuildPackaging Extra Small
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@TravisEz13 @daxian-dbw @adityapatwardhan