Sitelet https://web.archive.org/web/20220408175453/https://github.com/zulip/zulip/issues/21312
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace non-standard tooltip for "Announce stream" hint #21312

Open
alya opened this issue Mar 3, 2022 · 9 comments · May be fixed by #21571
Open

Replace non-standard tooltip for "Announce stream" hint #21312

alya opened this issue Mar 3, 2022 · 9 comments · May be fixed by #21571
Assignees
@raghavluthra20
Labels
area: stream settings good first issue help wanted in progress

Comments

@alya
Copy link
Collaborator

@alya alya commented Mar 3, 2022

In the "Create stream" UI, we should make the hint for "Announce stream" match other settings by:

  1. Replacing the tooltip with a standard tippy tooltip.
  2. Replacing the icon with an i icon, like we use for the "Message retention period" hint.

Screen Shot 2022-03-03 at 1 16 42 PM
@zulipbot
Copy link
Member

@zulipbot zulipbot commented Mar 3, 2022

Hello @zulip/server-streams members, this issue was labeled with the "area: stream settings" label, so you may want to check it out!

@Rishabh-792
Copy link
Collaborator

@Rishabh-792 Rishabh-792 commented Mar 4, 2022

@zulipbot claim

@akbajwa
Copy link
Collaborator

@akbajwa akbajwa commented Mar 9, 2022

@alya Hey Alya. I am not able to find this corner of Create Streams. As it is written in the documentation "Note: You will only see the Create stream button if you have permission to create streams."

@alya
Copy link
Collaborator Author

@alya alya commented Mar 10, 2022

You can log in as Desdemona in the dev environment to get full permissions.

@zulipbot
Copy link
Member

@zulipbot zulipbot commented Mar 20, 2022 •
edited

Hello @Rishabh-792, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@raghavluthra20
Copy link
Collaborator

@raghavluthra20 raghavluthra20 commented Mar 24, 2022

@zulipbot claim

raghavluthra20 added a commit to raghavluthra20/zulip that referenced this issue Mar 26, 2022
@raghavluthra20
stream_settings: Replace non-standard tooltip for "Announce stream" h…
2d77517 
…int.

The tooltip for the "Announce Stream" hint was not consistent with the
rest of the settings so it has now been replaced with the standard tippy
tooltip. The "?" icon has also been replaced by the "i" icon to match
the other settings.

Fixes: zulip#21312.
@raghavluthra20 raghavluthra20 linked a pull request Mar 26, 2022 that will close this issue
Open
raghavluthra20 added a commit to raghavluthra20/zulip that referenced this issue Mar 27, 2022
@raghavluthra20
stream_settings: Replace non-standard tooltip for "Announce stream" h…
e425604 
…int.

The tooltip for the "Announce Stream" hint was not consistent with the
rest of the settings so it has now been replaced with the standard tippy
tooltip. The "?" icon has also been replaced by the "i" icon to match
the other settings.

Fixes: zulip#21312.
@raghavluthra20
Copy link
Collaborator

@raghavluthra20 raghavluthra20 commented Mar 27, 2022

Fixed in #21571.

raghavluthra20 added a commit to raghavluthra20/zulip that referenced this issue Mar 28, 2022
@raghavluthra20
stream_settings: Replace non-standard tooltip for "Announce stream" h…
972ac4c 
…int.

The tooltip for the "Announce Stream" hint was not consistent with the
rest of the settings so it has now been replaced with the standard tippy
tooltip. The "?" icon has also been replaced by the "i" icon to match
the other settings.

Fixes: zulip#21312.
@Ginohmk
Copy link
Collaborator

@Ginohmk Ginohmk commented Mar 29, 2022

@zulipbot claim

@zulipbot
Copy link
Member

@zulipbot zulipbot commented Mar 29, 2022

Hello @Ginohmk, it looks like someone has already claimed this issue! Since we believe multiple assignments to the same issue may cause some confusion, we encourage you to search for other unclaimed issues to work on. However, you can always reclaim this issue if no one is working on it.

We look forward to your valuable contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raghavluthra20 raghavluthra20

Labels
area: stream settings good first issue help wanted in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stream_settings: Replace non-standard tooltip for "Announce stream" hint. raghavluthra20/zulip
6 participants
@alya @zulipbot @Ginohmk @raghavluthra20 @Rishabh-792 @akbajwa