test: fix test-net-pingpong pummel test for non-IPV6 hosts #34359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
CI for containered Linux with pummel failing with this PR: https://ci.nodejs.org/job/node-test-commit-linux-containered/21317 CI for containered Linux with pummel succeeding with this PR: https://ci.nodejs.org/job/node-test-commit-linux-containered/21337/ |
addaleax
approved these changes
Jul 16, 2020
BridgeAR
approved these changes
Jul 16, 2020
tniessen
approved these changes
Jul 16, 2020
cjihrig
pushed a commit
that referenced
this issue
Jul 23, 2020
Use `common.hasIPv6` instead of an OS check for more reliable operation. PR-URL: #34359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this issue
Jul 27, 2020
Use `common.hasIPv6` instead of an OS check for more reliable operation. PR-URL: #34359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
Use `common.hasIPv6` instead of an OS check for more reliable operation. PR-URL: #34359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
Use `common.hasIPv6` instead of an OS check for more reliable operation. PR-URL: #34359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Use
common.localIPv6Hostsinstead of::1for more reliable operation incontainers in CI.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes