Sitelet https://web.archive.org/web/20220318012102/https://github.com/denoland/deno/issues/13413
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error cause reccursion information #13413

Open
crowlKats opened this issue Jan 18, 2022 · 3 comments
Open

Show error cause reccursion information #13413

crowlKats opened this issue Jan 18, 2022 · 3 comments

Comments

@crowlKats
Copy link
Member

@crowlKats crowlKats commented Jan 18, 2022

Node does this
(code tested is https://github.com/denoland/deno/blob/167982be9e7af35e6c12ef6c40c002200bf5e0c0/cli/tests/testdata/error_cause_recursive.ts)
image
We should do the same

@RushilMehra
Copy link

@RushilMehra RushilMehra commented Jan 19, 2022

Going to attempt to pick this issue up. Will take me some time to familiarize myself with everything

@Grubba27
Copy link

@Grubba27 Grubba27 commented Feb 23, 2022

Hello there! This issue is still open for contribuitons ? I would start by addeding another option for errors here at errors or somewhere else ? How could I test this ?
I have some implementation doubts also like, I'm able to always tell when this is happening ? or i would do this kind of message: "RangeError: Maximum call stack size exceeded"

@crowlKats
Copy link
Member Author

@crowlKats crowlKats commented Feb 26, 2022

Hey @Grubba27, @RushilMehra is still working on this, but feel free to take a stab at this. We implemented this in the object inspection recently (#13555); obviously this wont map to rust, but it might still give some ideas.

I would start by addeding another option for errors here at errors or somewhere else ?

Take a look at #13209, we changed https://github.com/denoland/deno/blob/main/core/error.rs.

How could I test this ?

In the issue description i have linked a file with the testcase.

I have some implementation doubts also like, I'm able to always tell when this is happening ?

Not sure what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants