New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions take 2 #1414
GitHub Actions take 2 #1414
Conversation
|
Appreciate the effort @ocefpaf! I read about the Travis changes, it's unfortunate. |
9f7ea71
to
7e3df58
Yeah. Travis-CI was the best CI service out there and always very generous to OSS. But this has been a slow death since last year when they got bought by Idera :-( |
9d90f71
to
1d7b448
f776dca
to
44de061
54f06a3
to
5f39b73
|
Running the notebooks in CI does make sense to me. But I don't want to break the current gallery before we have a new one. I think it's important for users that they can see the example notebooks without having to run anything. We have that feature now, and I don't think a cleaner repo is worth killing it. |
Fair enough. The last commit re-add the outputs. I cleanup a bit by removing unnecessary debug code that saved the HTML and the mplleaflet notebook that was broken b/c mplleaflet no longer works with modern matplotlin. |
|
Thanks, I’m a week off this week though and AFK, so I’ll take a look on Sunday if that’s okay |
There is no hurry. Thanks! |
|
hey, I cloned your repo. so hopefully .. I can recreate this issue :) I hope I'll get to fixing this in the course of next week... or maybe ... tomorrow. But can't promise |
fd28e0c
to
3846ed1
d271830
to
c47d1af
|
@Conengmo this is all conda now, no experimental The only missing piece are the docs. I'll work on them in another PR b/c this one is already overwhelmingly big. Do you mind taking a last look and merging it? |
|
Great that you got all these test working on Actions! |
Linux and notebook tests need mamba-org/mamba#579
The text was updated successfully, but these errors were encountered: