Sitelet https://web.archive.org/web/20220203012527/https://github.com/python/cpython/pull/26656
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34266: [pdb] handle ValueError from shlex.split() #26656

Merged
merged 5 commits into from Jul 3, 2021
Merged

bpo-34266: [pdb] handle ValueError from shlex.split() #26656

merged 5 commits into from Jul 3, 2021

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jun 10, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue34266
@iritkatriel iritkatriel changed the title handle ValueError from shlex.split() bpo-34266: handle ValueError from shlex.split() Jun 10, 2021
@iritkatriel
Copy link
Member Author

@iritkatriel iritkatriel commented Jun 10, 2021

@blueyed Are you able to review?

@iritkatriel @jacobtylerwalls
Update Misc/NEWS.d/next/Library/2021-06-10-21-53-46.bpo-34266.k3fxnm.rst
78715b4 
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@iritkatriel iritkatriel changed the title bpo-34266: handle ValueError from shlex.split() bpo-34266: [pdb] handle ValueError from shlex.split() Jun 14, 2021
@iritkatriel iritkatriel requested a review from terryjreedy Jun 14, 2021
@iritkatriel iritkatriel mentioned this pull request Jul 2, 2021
Closed
serhiy-storchaka
serhiy-storchaka reviewed Jul 3, 2021
View changes
Lib/pdb.py Outdated Show resolved Hide resolved
Lib/test/test_pdb.py Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka reviewed Jul 3, 2021
View changes
Lib/test/test_pdb.py Outdated Show resolved Hide resolved
iritkatriel
iritkatriel reviewed Jul 3, 2021
View changes
Lib/test/test_pdb.py Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka approved these changes Jul 3, 2021
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

LGTM.

@iritkatriel iritkatriel merged commit d968a63 into python:main Jul 3, 2021
12 of 13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 3, 2021

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 3, 2021

Sorry @iritkatriel, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d968a638fcbf9030c999cfacd4c9bf0656e779c4 3.10

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 3, 2021

GH-27005 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 3, 2021
@iritkatriel @miss-islington
bpo-34266: [pdb] handle ValueError from shlex.split() (pythonGH-26656)
b0cb954 
(cherry picked from commit d968a63)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jul 3, 2021
@iritkatriel @iritkatriel
[3.10] bpo-34266: [pdb] handle ValueError from shlex.split() (pythonG…
49cf23b 
…H-26656)

(cherry picked from commit d968a63)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 3, 2021

GH-27006 is a backport of this pull request to the 3.10 branch.

iritkatriel added a commit that referenced this issue Jul 3, 2021
@iritkatriel @miss-islington
bpo-34266: [pdb] handle ValueError from shlex.split() (GH-26656) (GH-…
21be6cb 
…27005)

(cherry picked from commit d968a63)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit that referenced this issue Jul 3, 2021
@iritkatriel
[3.10] bpo-34266: [pdb] handle ValueError from shlex.split() (GH-26656)…
33022f9 
… (GH-27006)

(cherry picked from commit d968a63)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@iritkatriel iritkatriel deleted the bpo-34266 branch Aug 2, 2021
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@iritkatriel @JuniorJPDJ
bpo-34266: [pdb] handle ValueError from shlex.split() (pythonGH-26656)
ba0fe63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls

@serhiy-storchaka serhiy-storchaka

@terryjreedy terryjreedy

Assignees

@iritkatriel iritkatriel

Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
6 participants
@iritkatriel @miss-islington @bedevere-bot @serhiy-storchaka @jacobtylerwalls @the-knights-who-say-ni