Image caching is too aggressive #424

pizzafox · 2020-11-01T18:01:53Z

Describe the bug

When using an image URL like https://bundlephobia.com/api/stats-image?name=convert&version=1.0.1&wide=true for a version that isn't published the image returns a placeholder, but the placeholder gets cached. After the version is published the placeholder image stays cached.

To Reproduce

Visit an image URL for a version that didn't exist at image generation time.

Example: https://bundlephobia.com/api/stats-image?name=convert&version=1.1.0&wide=true

bundlephobia/server/middlewares/generateImg.middleware.js

Lines 30 to 33 in a604672

    
           } catch (err) { 
        
             console.error(err) 
        
             await send(ctx, 'client/assets/public/android-chrome-192x192.png') 
        
           }

Expected behavior

There should be a much shorter cache period for placeholder images.

pizzafox added the bug label Nov 1, 2020

pastelsky / bundlephobia

Image caching is too aggressive #424

Image caching is too aggressive #424

pizzafox commented Nov 1, 2020 •

edited

pastelsky / bundlephobia

Sponsor pastelsky/bundlephobia

Join GitHub today

GitHub is where the world builds software

Image caching is too aggressive #424

Image caching is too aggressive #424

Comments

pizzafox commented Nov 1, 2020 • edited

Essential cookies

Always active

Analytics cookies

pizzafox commented Nov 1, 2020 •

edited