Sitelet https://web.archive.org/web/20260531085303/https://github.com/github/docs/pull/14915
Skip to content

Adding explanation that service containers should not be used in composite actions#14915

Merged
ramyaparimi merged 6 commits into
github:mainfrom
nikola-jokic:patch-3
Mar 30, 2022
Merged

Adding explanation that service containers should not be used in composite actions#14915
ramyaparimi merged 6 commits into
github:mainfrom
nikola-jokic:patch-3

Conversation

@nikola-jokic
Copy link
Copy Markdown
Contributor

@nikola-jokic nikola-jokic commented Feb 1, 2022

Why:

Regarding the filed issue #14905, and related to the actions/runner repository issue #1526, added the explicit line explaining that service containers are not supported to be run inside the composite action

What's being changed:

Added one line explaining that service containers should not be used in composite actions

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

This should clarify to users the purpose of the service containers and how should they be used in this version of actions/runner

@nikola-jokic
service containers should not be used in composite actions
622a489 
Explanation that service container should not be used inside the composite actions
@nikola-jokic
Merge branch 'github:main' into patch-3
73b378b
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 1, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/using-containerized-services/about-service-containers.md Modified Original

@github-actions github-actions Bot temporarily deployed to docs-14915--patch-3 February 1, 2022 16:04 Inactive
@github-actions github-actions Bot temporarily deployed to docs-14915--patch-3 February 2, 2022 08:17 Inactive
@ramyaparimi ramyaparimi linked an issue Feb 2, 2022 that may be closed by this pull request
Update docs about service containers to explain that they should not be used within composite actions #14905
Closed
1 task
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Feb 2, 2022
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Feb 2, 2022

@nikola-jokic
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added the needs SME This proposal needs review from a subject matter expert label Mar 25, 2022
lucascosti
lucascosti reviewed Mar 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lucascosti lucascosti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one teeny wording change.

Comment thread content/actions/using-containerized-services/about-service-containers.md Outdated
@lucascosti lucascosti added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Mar 28, 2022
lucascosti
lucascosti approved these changes Mar 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge when the deployment freeze is finished 🚀

@ramyaparimi ramyaparimi enabled auto-merge March 30, 2022 13:59
@ramyaparimi ramyaparimi merged commit 6a61200 into github:main Mar 30, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@nikola-jokic nikola-jokic deleted the patch-3 branch March 30, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lucascosti lucascosti lucascosti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update docs about service containers to explain that they should not be used within composite actions

3 participants

@nikola-jokic @ramyaparimi @lucascosti