build: fix npm version detection #41575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Npm's package.json now contains two fields named "version". Grep for the top-level one. Fixes: nodejs/build#2850
|
Fast-track has been requested by @targos. Please |
|
Requesting to fast-track because this is blocking today's 17.x release. |
aduh95
approved these changes
Jan 18, 2022
|
/cc @nodejs/collaborators I have very little time left to do the release. |
vdeturckheim
approved these changes
Jan 18, 2022
panva
approved these changes
Jan 18, 2022
evanlucas
approved these changes
Jan 18, 2022
richardlau
approved these changes
Jan 18, 2022
lpinca
approved these changes
Jan 18, 2022
Lxxyx
approved these changes
Jan 18, 2022
cclauss
approved these changes
Jan 18, 2022
tniessen
approved these changes
Jan 18, 2022
Commit Queue failed- Loading data for nodejs/node/pull/41575 ✔ Done loading data for nodejs/node/pull/41575 ----------------------------------- PR info ------------------------------------ Title build: fix npm version detection (#41575) Author Michaël Zasso (@targos) Branch targos:fix-pkg -> nodejs:master Labels build, fast-track, author ready, needs-ci Commits 1 - build: fix npm version detection Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/41575 Fixes: https://github.com/nodejs/build/issues/2850 Reviewed-By: Antoine du Hamel Reviewed-By: Vladimir de Turckheim Reviewed-By: Filip Skokan Reviewed-By: Evan Lucas Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Zijian Liu Reviewed-By: Matteo Collina Reviewed-By: Christian Clauss Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41575 Fixes: https://github.com/nodejs/build/issues/2850 Reviewed-By: Antoine du Hamel Reviewed-By: Vladimir de Turckheim Reviewed-By: Filip Skokan Reviewed-By: Evan Lucas Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Zijian Liu Reviewed-By: Matteo Collina Reviewed-By: Christian Clauss Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 18 Jan 2022 10:39:35 GMT ✔ Approvals: 10 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855244531 ✔ - Vladimir de Turckheim (@vdeturckheim): https://github.com/nodejs/node/pull/41575#pullrequestreview-855256162 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/41575#pullrequestreview-855257311 ✔ - Evan Lucas (@evanlucas): https://github.com/nodejs/node/pull/41575#pullrequestreview-855285931 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855297007 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41575#pullrequestreview-855300576 ✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/41575#pullrequestreview-855303507 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855307827 ✔ - Christian Clauss (@cclauss): https://github.com/nodejs/node/pull/41575#pullrequestreview-855343615 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855377040 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1712846536 |
|
Landed in 331b906 |
targos
added a commit
that referenced
this issue
Jan 18, 2022
Npm's package.json now contains two fields named "version". Grep for the top-level one. Fixes: nodejs/build#2850 PR-URL: #41575 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
added a commit
that referenced
this issue
Jan 18, 2022
Npm's package.json now contains two fields named "version". Grep for the top-level one. Fixes: nodejs/build#2850 PR-URL: #41575 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
thedull
pushed a commit
to thedull/node
that referenced
this issue
Jan 18, 2022
Npm's package.json now contains two fields named "version". Grep for the top-level one. Fixes: nodejs/build#2850 PR-URL: nodejs#41575 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this issue
Jan 31, 2022
Npm's package.json now contains two fields named "version". Grep for the top-level one. Fixes: nodejs/build#2850 PR-URL: nodejs#41575 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this issue
Feb 1, 2022
Npm's package.json now contains two fields named "version". Grep for the top-level one. Fixes: nodejs/build#2850 PR-URL: #41575 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Npm's package.json now contains two fields named "version".
Grep for the top-level one.
Fixes: nodejs/build#2850