Sitelet https://web.archive.org/web/20220105232015/https://github.com/jenkins-x/jx/issues/8037
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting checks pass even if exported structs do not have any comments #8037

Open
ankitm123 opened this issue Jan 5, 2022 · 3 comments
Open

linting checks pass even if exported structs do not have any comments #8037

ankitm123 opened this issue Jan 5, 2022 · 3 comments

Comments

@ankitm123
Copy link
Member

@ankitm123 ankitm123 commented Jan 5, 2022 •

Not sure what the error is, but lint passes in the CI and locally even if exported structs dont have comments.
Most probably, it's an issue with the golangci yaml config we use.

Also we use revive instead of golint (which is deprecated), may be some setting in revive needs to be enabled?

If we check the goreport card, we can see the issues: https://goreportcard.com/report/github.com/jenkins-x/jx#golint

@sgmac
Copy link

@sgmac sgmac commented Jan 5, 2022 •

@ankitm123 I'd like to work on this.

@sgmac
Copy link

@sgmac sgmac commented Jan 5, 2022

/assign

@ankitm123
Copy link
Member Author

@ankitm123 ankitm123 commented Jan 5, 2022

/assign @sgmac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants