Ruby: taint steps for pattern matches#7568
Merged
Merged
Conversation
hvitved
requested changes
Jan 18, 2022
Contributor
hvitved
left a comment
There was a problem hiding this comment.
Looks great! Could you please start a DCA run as well?
9987006 to
139e8a0
Compare
hvitved
reviewed
Jan 19, 2022
d85f630 to
ca2540c
Compare
hvitved
requested changes
Jan 19, 2022
Contributor
hvitved
left a comment
There was a problem hiding this comment.
Looks great. Some trivial comments.
2987d0c to
91a3dca
Compare
hvitved
reviewed
Jan 24, 2022
91a3dca to
78b4d7c
Compare
Joining on variable name alone is a bad thing:
```
[2022-01-25 11:13:20] (228s) Tuple counts for Variable::Cached::access#ff#shared/3@868b54tu after 3m37s:
112554 ~0% {3} r1 = JOIN Variable::VariableReal::getNameImpl_dispred#ff WITH Variable::VariableReal::getDeclaringScopeImpl_dispred#ff ON FIRST 1 OUTPUT Lhs.1, Lhs.0 'arg2', Rhs.1 'arg1'
561015756 ~1% {3} r2 = JOIN r1 WITH Variable::variableName#ff_10#join_rhs ON FIRST 1 OUTPUT Rhs.1 'arg0', Lhs.2 'arg1', Lhs.1 'arg2'
return r2
```
This change ensures that we join on name and scope simultaneously.
hvitved
approved these changes
Jan 26, 2022
Contributor
hvitved
left a comment
There was a problem hiding this comment.
Performance looks good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds taint steps from the value of a
caseexpression to the variables in the patterns the value is matched against.