Sitelet https://web.archive.org/web/20220414085726/https://github.com/JuliaLang/julia/issues/43369
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"rationalize" a rational #43369

Open
ParadaCarleton opened this issue Dec 8, 2021 · 3 comments · May be fixed by #43427
Open

"rationalize" a rational #43369

ParadaCarleton opened this issue Dec 8, 2021 · 3 comments · May be fixed by #43427
Labels
good first issue

Comments

@ParadaCarleton
Copy link

@ParadaCarleton ParadaCarleton commented Dec 8, 2021

It might be useful to have rationalize(x) return x if x is already rational, to allow generic code that takes both reals and rationals as inputs.
@oscardssmith oscardssmith added the good first issue label Dec 8, 2021
@jlazar17 jlazar17 mentioned this issue Dec 8, 2021
Open
@ayushsengupta8
Copy link

@ayushsengupta8 ayushsengupta8 commented Dec 9, 2021

Hello,
I am completely new to open source projects and would like to try to solve this issue.
I can use a convert() function to rationalize(x), however, it would be helpful if I know in which folder, in which file do I have to change/add the code. @logankilpatrick

@fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Dec 9, 2021

As you can see by the link just above your comment someone has already started to work on this.

@ayushsengupta8
Copy link

@ayushsengupta8 ayushsengupta8 commented Dec 9, 2021

@fredrikekre Oh! Thanks...and sorry for the lame comment

@tantheta01 tantheta01 linked a pull request Dec 15, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add method to rationalize Rational tantheta01/julia
4 participants
@fredrikekre @oscardssmith @ayushsengupta8 @ParadaCarleton