bpo-43118: in inspect.signature,use 'base' to help parse 'base.__text_signature__' #30285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
reviewed
Jan 19, 2022
Misc/NEWS.d/next/Library/2021-12-29-14-42-09.bpo-43118.BoVi_5.rst
Outdated
Show resolved
Hide resolved
JelleZijlstra
reviewed
Jan 19, 2022
JelleZijlstra
reviewed
Jan 19, 2022
JelleZijlstra
approved these changes
Jan 20, 2022
|
@gvanrossum I think this is ready to merge. |
|
Though we need to decide whether this should be backported to 3.9 and 3.10. I'd say yes since it's a bugfix and the old behavior was broken. |
|
Thanks @hongweipeng for the PR, and @gvanrossum for merging it |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2022
…__' (pythonGH-30285) (cherry picked from commit 881a763) Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
|
GH-30765 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2022
…__' (pythonGH-30285) (cherry picked from commit 881a763) Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
|
GH-30766 is a backport of this pull request to the 3.9 branch. |
|
I hope the commit title I made up covers the change. (If not, too bad -- we don't roll things back to fix commit messages.) |
gvanrossum
pushed a commit
that referenced
this pull request
Jan 22, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…__' (pythonGH-30285) (cherry picked from commit 881a763) Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue43118