Sitelet https://web.archive.org/web/20220122132010/https://github.com/zulip/zulip/issues/20831
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor bugs in bot management modal #20831

Open
alya opened this issue Jan 18, 2022 · 10 comments
Open

Fix minor bugs in bot management modal #20831

alya opened this issue Jan 18, 2022 · 10 comments
Assignees
@NerdyLucifer
Labels
area: popovers area: settings (admin/org) bug good first issue help wanted in progress

Comments

@alya
Copy link
Collaborator

@alya alya commented Jan 18, 2022

As reported by @Rishabh-792 here, there are two minor issues in the bot management modal:

  1. At present, the "Remove owner" link is always shown. We should not show the link when there is no owner.
  2. The "Save changes" button should be disabled when no changes have been made.

It's fine to submit separate PRs for these two issues.

Screenshot-from-2022-01-17-21-59-02
@zulipbot
Copy link
Member

@zulipbot zulipbot commented Jan 18, 2022

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (admin/org)" label, so you may want to check it out!

@NerdyLucifer
Copy link
Collaborator

@NerdyLucifer NerdyLucifer commented Jan 19, 2022

@zulipbot claim

@zulipbot
Copy link
Member

@zulipbot zulipbot commented Jan 19, 2022

Hello @NerdyLucifer, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@NerdyLucifer
Copy link
Collaborator

@NerdyLucifer NerdyLucifer commented Jan 19, 2022

@zulipbot claim

@vivekrajput566
Copy link
Collaborator

@vivekrajput566 vivekrajput566 commented Jan 19, 2022

@zulipbot claim.

@zulipbot
Copy link
Member

@zulipbot zulipbot commented Jan 19, 2022

Hello @vivekrajput566, it looks like someone has already claimed this issue! Since we believe multiple assignments to the same issue may cause some confusion, we encourage you to search for other unclaimed issues to work on. However, you can always reclaim this issue if no one is working on it.

We look forward to your valuable contributions!

NerdyLucifer added a commit to NerdyLucifer/zulip that referenced this issue Jan 19, 2022
@NerdyLucifer
bot_settings_modal: Hide 'Remove owner' button when there is no owner.
25065bd 
Hides 'Remove owner' button when there is no owner assigned
to the bot by removing ':enabled' selector from the button.

Fixes part of zulip#20831.
@NerdyLucifer NerdyLucifer mentioned this issue Jan 19, 2022
Open
NerdyLucifer added a commit to NerdyLucifer/zulip that referenced this issue Jan 20, 2022
@NerdyLucifer
bot_settings_modal: Hide 'Remove owner' button when there is no owner.
ec9ea80 
Hides 'Remove owner' button when there is no owner assigned
to the bot by removing ':enabled' selector from the button,
the button is not actually a button, it's an <a> tag which
doesn't support "disabled" attribute.

Fixes part of zulip#20831.
@vivekrajput566
Copy link
Collaborator

@vivekrajput566 vivekrajput566 commented Jan 20, 2022

@NerdyLucifer @alya how you find js code in the files as i am new in open source community so can you help me?

@NerdyLucifer
Copy link
Collaborator

@NerdyLucifer NerdyLucifer commented Jan 20, 2022

@vivekrajput566 Please go through the directory structure in the Contributor's Doc
https://zulip.readthedocs.io/en/latest/overview/directory-structure.html#

@alya
Copy link
Collaborator Author

@alya alya commented Jan 20, 2022

@vivekrajput566 please take a look at the Zulip contributor guide to learn how to get started. Also, keep in mind the following guideline:

Before you claim an issue, you should be confident that you will be able to tackle it effectively.

Note that this issue is already assigned to @NerdyLucifer .

@vivekrajput566
Copy link
Collaborator

@vivekrajput566 vivekrajput566 commented Jan 21, 2022

@alya @NerdyLucifer thanks to both of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NerdyLucifer NerdyLucifer

Labels
area: popovers area: settings (admin/org) bug good first issue help wanted in progress
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@alya @zulipbot @vivekrajput566 @NerdyLucifer