Python: Deprecate old points-to based modeling #7660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a3ed40 to
ad65ad3
Compare
9d04b02 to
94f9656
Compare
Member
Author
|
Very excited to announce that all checks now pass, so this can be reviewed 🎉 |
tausbn
approved these changes
Feb 11, 2022
Contributor
tausbn
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for doing this.
Regarding the tests, instead of adding the deprecation warnings to the expected output, I wonder if we should just delete them outright.
Member
Author
I think some of the tests could still have value if we want to port the (old) experimental queries away from points-to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this with search/replace regex. Draft PR to see what sort of failures come up.