Sitelet https://web.archive.org/web/20210125030053/https://github.com/microsoft/vscode-java-debug/pull/829
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the specified classes on exception breakpoint or stepping #829

Merged
merged 3 commits into from Jul 1, 2020

Conversation

@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Jun 12, 2020

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

It requires microsoft/java-debug#334

Close #756
Close #628

@testforstephen testforstephen requested review from Eskibear, andxu, jdneo and akaroml and removed request for Eskibear Jun 12, 2020
@testforstephen
Copy link
Contributor Author

@testforstephen testforstephen commented Jun 12, 2020 •

When you just want to break on exception for "Just My Code", you can

    "java.debug.settings.exceptionBreakpoint.skipClasses": [
        "$JDK", // Skip the JDK classes from the default system bootstrap classpath, such as rt.jar, jrt-fs.jar.
        "$Libraries" // Skip the classes from application libraries, such as Maven, Gradle dependencies.
    ],

When you just want to step into "Just My Code", then you can

    "java.debug.settings.stepping.skipClasses": [
        "$JDK", // Skip the JDK classes from the default system bootstrap classpath, such as rt.jar, jrt-fs.jar.
        "$Libraries" // Skip the classes from application libraries, such as Maven, Gradle dependencies.
    ]

Also, you could add a specific class name expression, e.g. java.*, *.Foo to skip the classes.

@testforstephen testforstephen added this to the 0.27.0 milestone Jun 12, 2020
src/classFilter.ts Outdated Show resolved Hide resolved
src/classFilter.ts Outdated Show resolved Hide resolved
@Eskibear
Copy link
Member

@Eskibear Eskibear commented Jun 30, 2020

Here at a user's perspective, I don't see the meaning of $JDK and $Libraries.

  • $JDK, does it mean java.* and javax., or even including javafx.? Then why there's an explicit java.lang.classloader in default value?
  • $Library. This is vague, it might be better to add more description?
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@testforstephen testforstephen force-pushed the testforstephen:jinbo_filter branch from ea20c99 to 40d3031 Jul 1, 2020
@testforstephen
Copy link
Contributor Author

@testforstephen testforstephen commented Jul 1, 2020

Here at a user's perspective, I don't see the meaning of $JDK and $Libraries.

  • $JDK, does it mean java.* and javax., or even including javafx.? Then why there's an explicit java.lang.classloader in default value?
  • $Library. This is vague, it might be better to add more description?

Reasonable concern. Addressed.

@jdneo
jdneo approved these changes Jul 1, 2020
@testforstephen testforstephen merged commit cc40399 into microsoft:master Jul 1, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@testforstephen testforstephen deleted the testforstephen:jinbo_filter branch Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants