Add a default user agent to REST source calls #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Jan 8, 2022
|
The WinINet downloader uses the user-agent |
|
Based on some internal discussion with @denelon, I've updated the actual user agent string (see PR description for new format). It will still be used in the same locations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change
Provides a default user agent header in the http helper class that the REST source code uses. It can be overridden by providing the user agent header in the headers argument.
The default format is:
where
1.2.3is the client version as would be output bywinget -v(without thevat the beginning) and10.11.12is the package version of the MSIX.Also updates the WinINET downloader to use the same user agent string, but it is not overridable.
Validation
Added a unit test to ensure that the default was being set properly for both
GETandPOST.Microsoft Reviewers: Open in CodeFlow