Allow upgrades in packages that register a different installer type #1796
Conversation
|
Another test case for this is iTunes, it packages a msi inside a exe. If you add this ARP entry: to the manifest, it works great! |
|
This addresses at least one version of Adobe Acrobat, and PowerToys (@crutkas). |
| @@ -210,6 +210,21 @@ namespace | |||
| PackageMatchFilter(PackageMatchField::Id, MatchType::Exact, "AppInstallerCliTest.TestExeInstaller"))); | |||
| } | |||
|
|
|||
| if (input == "TestExeInstallerWithDifferentInstalledType") | |||
There was a problem hiding this comment.
I'm not a fan of how long this function is getting. Many tests seem to use only a single case of all this and most are used in a single test, so we probably could add a constructor that took the manifests and always returned that. It would also put the search results closer to where it's used. Putting this here to see what others think of doing that..
There was a problem hiding this comment.
Agree, making it easy to create specific new cases rather than extending this would be good.
| @@ -210,6 +210,21 @@ namespace | |||
| PackageMatchFilter(PackageMatchField::Id, MatchType::Exact, "AppInstallerCliTest.TestExeInstaller"))); | |||
| } | |||
|
|
|||
| if (input == "TestExeInstallerWithDifferentInstalledType") | |||
There was a problem hiding this comment.
Agree, making it easy to create specific new cases rather than extending this would be good.
InstalledTypeComparatorto also consider the installer types listed underAppsAndFeaturesEntriesExplainInapplicableto also mention the installed type and other types accepted by the manifest.Closes #1242. Validated that upgrading PowerToys (mentioned in that issue) worked correctly using a local manifest edited to include the
AppsAndFeaturesEntriesand installed typemsi.Microsoft Reviewers: Open in CodeFlow