Sitelet https://web.archive.org/web/20220125174400/https://github.com/apache/kafka/pull/11595
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: timeout waitForBlock in connect BlockingConnectorTest #11595

Merged
merged 1 commit into from Dec 15, 2021
Merged

MINOR: timeout waitForBlock in connect BlockingConnectorTest #11595

merged 1 commit into from Dec 15, 2021

Conversation

@lbradstreet
Copy link
Contributor

@lbradstreet lbradstreet commented Dec 11, 2021

I've noticed some builds timing out on BlockingConnectorTest. This adds a timeout around the latch usage.
C0urante
C0urante approved these changes Dec 14, 2021
View changes
Copy link
Contributor

@C0urante C0urante left a comment •
edited

This is a good safeguard so LGTM 👍

I'm curious about where you're seeing the timeouts, though. Barring environmental issues like laggy overloaded laptop/CI builds, this measure shouldn't be necessary unless there's a bug in the testing logic here.

@lbradstreet
Copy link
Contributor Author

@lbradstreet lbradstreet commented Dec 14, 2021

@C0urante I did see a build get stuck here for a couple of hours. Unfortunately jenkins has dropped the history and I wasn't bright enough to capture any logs in time. Hopefully we'll be able to figure it out when (or if) this test eventually throws.

@C0urante
Copy link
Contributor

@C0urante C0urante commented Dec 14, 2021

Thanks @lbradstreet. Would you mind pinging me if/when you see this again? Don't like seeing my tests causing everyone's builds to turn red 😠

@lbradstreet
Copy link
Contributor Author

@lbradstreet lbradstreet commented Dec 15, 2021

Thanks @lbradstreet. Would you mind pinging me if/when you see this again? Don't like seeing my tests causing everyone's builds to turn red 😠

I definitely will, thanks. Don't worry though, the build was grey! :P

mimaison
mimaison approved these changes Dec 15, 2021
View changes
Copy link
Member

@mimaison mimaison left a comment

LGTM, thanks for the PR

@mimaison
Copy link
Member

@mimaison mimaison commented Dec 15, 2021

Tests passed locally, merging

@mimaison mimaison merged commit b4602e8 into apache:trunk Dec 15, 2021
0 of 10 checks passed
xdgrulez pushed a commit to xdgrulez/kafka that referenced this issue Dec 22, 2021
@lbradstreet Ralph Debusmann
MINOR: Timeout waitForBlock in connect BlockingConnectorTest (apache#…
041ed0d 
…11595)


Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chris Egerton <fearthecellos@gmail.com>
yangl added a commit to yangl/kafka that referenced this issue Jan 18, 2022
@lbradstreet @yangl
MINOR: Timeout waitForBlock in connect BlockingConnectorTest (apache#…
e1619c0 
…11595)


Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chris Egerton <fearthecellos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimaison mimaison

@C0urante C0urante

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lbradstreet @C0urante @mimaison