Sitelet https://web.archive.org/web/20211228073542/https://github.com/zulip/zulip/issues/20618
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sorting algorithm for stream name typeahead #20618

Open
alya opened this issue Dec 22, 2021 · 4 comments
Open

Improve sorting algorithm for stream name typeahead #20618

alya opened this issue Dec 22, 2021 · 4 comments
Assignees
@srdeotarse
Labels
area: compose good first issue help wanted in progress

Comments

@alya
Copy link
Collaborator

@alya alya commented Dec 22, 2021 •
edited

At present, in stream typeahead in the compose box, we sort pinned streams > subscribed streams > other streams, with message volume serving as the tie breaker.

To improve the likelihood that the desired streams are sorted at the top, we should change the ordering to be:

stream that the message is addressed to (if any) > unmuted pinned streams > unmuted subscribed streams > muted streams > other streams

We don't need to make any changes to the tie breaker.

For discussion and pointers to the relevant parts of the code, see this CZO thread.
@zulipbot
Copy link
Member

@zulipbot zulipbot commented Dec 22, 2021

Hello @zulip/server-compose members, this issue was labeled with the "area: compose" label, so you may want to check it out!

@srdeotarse
Copy link
Collaborator

@srdeotarse srdeotarse commented Dec 23, 2021

@zulipbot claim

@zulipbot
Copy link
Member

@zulipbot zulipbot commented Dec 23, 2021

Hello @srdeotarse, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@srdeotarse
Copy link
Collaborator

@srdeotarse srdeotarse commented Dec 23, 2021

@zulipbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srdeotarse srdeotarse

Labels
area: compose good first issue help wanted in progress
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@alya @zulipbot @srdeotarse