Sitelet https://web.archive.org/web/20220617004300/https://github.com/altair-graphql/altair/issues/1717
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write more tests #1717

Open
imolorhe opened this issue Oct 17, 2021 · 2 comments
Open

Write more tests #1717

imolorhe opened this issue Oct 17, 2021 · 2 comments
Labels
good first issue hacktoberfest help wanted

Comments

@imolorhe
Copy link
Collaborator

@imolorhe imolorhe commented Oct 17, 2021

While there are already lots of tests, several components are still lacking proper tests (just the one skeletal generated test). It would be nice to have tests for a lot of such components.
@OrchiDorchi
Copy link

@OrchiDorchi OrchiDorchi commented Nov 23, 2021

I am looking forward to work on this issue. Can you provide the tests path and some sample tests?
Thanks.

@imolorhe
Copy link
Collaborator Author

@imolorhe imolorhe commented Nov 23, 2021

Oh thank you!

The test files are along side the source files in the same directory. For instance, the test file for environment.service.ts is environment.service.spec.ts.

Same for components as well. For example, the test for header.component.ts (which is one of the empty tests) is header.component.spec.ts. An example of a component spec with some valid tests is add-collection-query-dialog.component.spec.ts

@adam-osu adam-osu mentioned this issue Jun 4, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imolorhe @OrchiDorchi