Sitelet https://web.archive.org/web/20220111163236/https://github.com/flutter/flutter/pull/96435
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InkWell.overlayColor is now resolved against MaterialState.pressed #96435

Merged
merged 1 commit into from Jan 11, 2022

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Jan 11, 2022 •

InkWell's overlayColor property is now resolved against MaterialState.pressedState along with MaterialState.hovered and MaterialState.focused (as before).

This PR was factored out of #96252 because the InkWell.overlayColor MaterialStateProperty resolution changes affected a few internal golden image tests - #96252 (comment).

Internal Google updates for these changes: cl/420793326

@KalilDev
Copy link
Contributor

@KalilDev KalilDev commented Jan 11, 2022

I was about to open an issue for this, as i had some issues while theming the state overlay. In my solution i also removed the overlayColor usage for theming the splash, here and here, along with the relevant section on the documentation. I think this should be done because otherwise the overlayColor would be incorrectly used to theme the unrelated splashColor, violating the user's expectations and leading to confusion. What do you think about this?

@HansMuller
Copy link
Contributor Author

@HansMuller HansMuller commented Jan 11, 2022

@KalilDev - I agree with you that just using the splashColor to render ink splashes would be more intuitive. Undoing the existing code/doc as you've suggested would likely cause some breaks in (Google internal) golden image tests. If you'll open an issue, I'll try and address the problem in a separate PR.

@HansMuller
Copy link
Contributor Author

@HansMuller HansMuller commented Jan 11, 2022

Must be rolled with (internal Google link) cl/420793326

@HansMuller HansMuller merged commit 7d4497a into flutter:master Jan 11, 2022
65 checks passed
@HansMuller HansMuller deleted the inkwell_overlay_color_pressed branch Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants