build(docs-infra): update docs examples to Angular v13.0.0-rc.0 #43880

gkalpak · 2021-10-18T17:58:19Z

This PR updates the docs examples to Angular v13.0.0-rc.0. In addition to updating the dependency versions, it also updates the projects' structure and configs to more closely match what a new v13 CLI app would look like. See, also, the diff between a basic v12.1.3 CLI app and a v13.0.0-rc.0 one.
(NOTE: v12.1.3 was the last version for which we aligned the projects with how a new CLI app would look like.)

Additionlly:

Since we now use RxJS v7 in docs examples, this commit removes the extra CI steps to explicitly test the docs examples against RxJS v7.
Since Angular v13 no longer supports IE, this commit removes an IE-specific section from upgrade-setup.md.

The text was updated successfully, but these errors were encountered:

mary-poppins · 2021-10-18T18:07:16Z

You can preview bd732c4 at https://pr43880-bd732c4.ngbuilds.io/.

mary-poppins · 2021-10-18T19:43:07Z

You can preview 420b05d at https://pr43880-420b05d.ngbuilds.io/.

This commit updates the version of Chrome used in non-bazel tests (via Puppeteer) to the latest (v93).

… with RxJS v7 Due to how `debounceTime()` works in RxJS v7, Jasmine's mock clock was not enough to trigger it. This commit fixes it by providing a similar mock clock that is able to mock all of `Date.now()`, `setInterval()` and `setTimeout()`.

This commit updates the docs examples to Angular v13.0.0-rc.0. In addition to updating the dependency versions, it also updates the projects' structure and configs to more closely match what a new v13 CLI app would look like. See, also, the [diff][1] between a basic v12.1.3 CLI app and a v13.0.0-rc.0 one. (NOTE: v12.1.3 was the last version for which we aligned the projects with how a new CLI app would look like.) Additionlly: - Since we now use RxJS v7 in docs examples, this commit removes the extra CI steps to explicitly test the docs examples against RxJS v7. - Since Angular v13 no longer supports IE, this commit removes an IE-specific section from `upgrade-setup.md`. [1]: https://github.com/cexbrayat/angular-cli-diff/compare/12.1.3..13.0.0-rc.0

This commit enable the `noImplicitOverride` and `noPropertyAccessFromIndexSignature` TypeScript compiler options for docs examples to better align with the default configuration of new Angular CLI apps. It also makes the necessary changes to the docs examples source code.

mary-poppins · 2021-10-19T13:58:09Z

You can preview 488114f at https://pr43880-488114f.ngbuilds.io/.

AndrewKushnir

Thanks for updating AIO to use v13. This would also unblock further updates of https://angular.io/guide/dynamic-component-loader guide (and other examples) to use new ViewContainerRef.createComponent API.

crisbeto · 2021-10-26T11:20:26Z

aio/tools/examples/shared/package.json

-    "@angular/service-worker": "13.0.0-next.9",
-    "@angular/upgrade": "13.0.0-next.9",
-    "@nguniversal/express-engine": "~12.1.0",
+    "@angular/animations": "~13.0.0-next.0",


The PR description says rc.0, but this downgrades to next.0.

Wow! I don't know what happened here 😱
I'll update the version to rc.1 (now that it's available) 😅

Ah, wait! I know what happened here 😁

Here I am aligning the package.json files with what a brand new 13.0.0-rc.0 CLI app would look like (see here).
In the lockfile, you can see that the actual versions used are indeed 13.0.0-rc.0.

The reason the versions in package.json were higher is that people often update the docs examples without following the instructions (just by updating the versions in package.json and the lockfile). But it is better to align with what a new CLI app would look like (even if that means having a broader version range in package.json).

petebacondarwin · 2021-10-26T11:21:43Z

aio/content/examples/practical-observable-usage/src/typeahead.spec.ts

 import { docRegionTypeahead } from './typeahead';

 describe('typeahead', () => {
  let document: Document;
  let ajax: jasmine.Spy;
+  let tick: MockClock['tick'];


Why not use fakeAsync instead of a hand-rolled solution?

These tests do not use Angular/Zone.js. They are plain ol' RxJS (in Node.js).

Oh right. It seems surprising that RxJS does not provider something like this out of the box.

Maybe it does and I couldn't figure it out 😅
I know they have a TestScheduler, but couldn't figure out how to use it without modifying/complicating the original code 🤷‍♂️

petebacondarwin · 2021-10-26T11:21:43Z

aio/tools/examples/shared/boilerplate/cli-ajs/package.json

-    "@angular/platform-browser": "13.0.0-next.7",
-    "@angular/platform-browser-dynamic": "13.0.0-next.7",
-    "@angular/router": "13.0.0-next.7",
+    "@angular/animations": "~13.0.0-next.0",


This could probably be rc.1 now.

Here I am aligning with what a new CLI@13.0.0-rc.0 app would look like (see also https://github.com/angular/angular/pull/43880/files#r736589285). This version range would also match the latest RC (if one were to run npm/yarn install without a lockfile), so I think it is fine.

I could update @angular/cli to 13.0.0-rc.1, but even that uses ~13.0.0-next.0 for Angular framework packages (see this diff). Given that we should update the docs examples to v13 once it is released as stable, I think there is little benefit in updating CLI from .rc.0 to .rc.1 at this point.

aio/tools/examples/shared/boilerplate/cli/tsconfig.json

alxhub

Approved-for: global-approvers

alxhub

Approved-for: global-approvers

alxhub

Reviewed-for: global-approvers

alxhub · 2021-10-29T20:10:29Z

This PR was merged into the repository by commit 7b35a34.

… with RxJS v7 (#43880) Due to how `debounceTime()` works in RxJS v7, Jasmine's mock clock was not enough to trigger it. This commit fixes it by providing a similar mock clock that is able to mock all of `Date.now()`, `setInterval()` and `setTimeout()`. PR Close #43880

This commit updates the docs examples to Angular v13.0.0-rc.0. In addition to updating the dependency versions, it also updates the projects' structure and configs to more closely match what a new v13 CLI app would look like. See, also, the [diff][1] between a basic v12.1.3 CLI app and a v13.0.0-rc.0 one. (NOTE: v12.1.3 was the last version for which we aligned the projects with how a new CLI app would look like.) Additionlly: - Since we now use RxJS v7 in docs examples, this commit removes the extra CI steps to explicitly test the docs examples against RxJS v7. - Since Angular v13 no longer supports IE, this commit removes an IE-specific section from `upgrade-setup.md`. [1]: https://github.com/cexbrayat/angular-cli-diff/compare/12.1.3..13.0.0-rc.0 PR Close #43880

…43880) This commit enable the `noImplicitOverride` and `noPropertyAccessFromIndexSignature` TypeScript compiler options for docs examples to better align with the default configuration of new Angular CLI apps. It also makes the necessary changes to the docs examples source code. PR Close #43880

) This commit updates the version of Chrome used in non-bazel tests (via Puppeteer) to the latest (v93). PR Close #43880

… with RxJS v7 (#43880) Due to how `debounceTime()` works in RxJS v7, Jasmine's mock clock was not enough to trigger it. This commit fixes it by providing a similar mock clock that is able to mock all of `Date.now()`, `setInterval()` and `setTimeout()`. PR Close #43880

This commit updates the docs examples to Angular v13.0.0-rc.0. In addition to updating the dependency versions, it also updates the projects' structure and configs to more closely match what a new v13 CLI app would look like. See, also, the [diff][1] between a basic v12.1.3 CLI app and a v13.0.0-rc.0 one. (NOTE: v12.1.3 was the last version for which we aligned the projects with how a new CLI app would look like.) Additionlly: - Since we now use RxJS v7 in docs examples, this commit removes the extra CI steps to explicitly test the docs examples against RxJS v7. - Since Angular v13 no longer supports IE, this commit removes an IE-specific section from `upgrade-setup.md`. [1]: https://github.com/cexbrayat/angular-cli-diff/compare/12.1.3..13.0.0-rc.0 PR Close #43880

…43880) This commit enable the `noImplicitOverride` and `noPropertyAccessFromIndexSignature` TypeScript compiler options for docs examples to better align with the default configuration of new Angular CLI apps. It also makes the necessary changes to the docs examples source code. PR Close #43880

IgorMinar · 2021-10-29T21:20:31Z

Thanks @gkalpak for doing this work!

angular-automatic-lock-bot · 2021-11-29T16:10:25Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

google-cla bot added the cla: yes label Oct 18, 2021

gkalpak added comp: build & ci comp: docs-infra target: rc labels Oct 18, 2021

ngbot bot added this to the Backlog milestone Oct 18, 2021

gkalpak force-pushed the build-update-angular-examples branch from bd732c4 to 420b05d Oct 18, 2021

gkalpak added 3 commits Oct 19, 2021

build: use the latest version of Chrome (v93) in non-bazel tests

a5c9e4b

This commit updates the version of Chrome used in non-bazel tests (via Puppeteer) to the latest (v93).

gkalpak force-pushed the build-update-angular-examples branch from 420b05d to 488114f Oct 19, 2021

gkalpak mentioned this pull request Oct 19, 2021

docs(upgrade): fix upgrade docs examples for v13 #43868

Closed

gkalpak marked this pull request as ready for review Oct 19, 2021

pullapprove bot requested review from alxhub, AndrewKushnir, atscott and jelbourn Oct 19, 2021

gkalpak added the action: review label Oct 19, 2021

AndrewKushnir approved these changes Oct 20, 2021

View changes

AndrewKushnir mentioned this pull request Oct 20, 2021

docs: update dynamic component guide to use factory-less ViewContainerRef.createComponent #43895

Closed

3 tasks

crisbeto reviewed Oct 26, 2021

View changes

petebacondarwin approved these changes Oct 26, 2021

View changes

petebacondarwin removed this from the Backlog milestone Oct 29, 2021

petebacondarwin added this to the v13 milestone Oct 29, 2021

atscott approved these changes Oct 29, 2021

View changes

alxhub approved these changes Oct 29, 2021

View changes

gkalpak removed the request for review from jelbourn Oct 29, 2021

gkalpak added action: merge and removed action: review labels Oct 29, 2021

alxhub approved these changes Oct 29, 2021

View changes

alxhub closed this in bc5e295 Oct 29, 2021

alxhub added a commit that referenced this issue Oct 29, 2021

build: use the latest version of Chrome (v93) in non-bazel tests (#43880

6ff9798

) This commit updates the version of Chrome used in non-bazel tests (via Puppeteer) to the latest (v93). PR Close #43880

gkalpak deleted the build-update-angular-examples branch Oct 29, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 29, 2021

angular / angular Public

build(docs-infra): update docs examples to Angular v13.0.0-rc.0 #43880

build(docs-infra): update docs examples to Angular v13.0.0-rc.0 #43880

gkalpak commented Oct 18, 2021

mary-poppins commented Oct 18, 2021

mary-poppins commented Oct 18, 2021

mary-poppins commented Oct 19, 2021

AndrewKushnir left a comment

crisbeto Oct 26, 2021

gkalpak Oct 26, 2021

gkalpak Oct 26, 2021

petebacondarwin Oct 26, 2021

gkalpak Oct 26, 2021

petebacondarwin Oct 26, 2021

gkalpak Oct 26, 2021

petebacondarwin Oct 26, 2021

gkalpak Oct 26, 2021

alxhub left a comment

alxhub left a comment

alxhub left a comment

alxhub commented Oct 29, 2021

IgorMinar commented Oct 29, 2021

angular-automatic-lock-bot bot commented Nov 29, 2021

angular / angular Public

build(docs-infra): update docs examples to Angular v13.0.0-rc.0 #43880

build(docs-infra): update docs examples to Angular v13.0.0-rc.0 #43880

Conversation

gkalpak commented Oct 18, 2021

mary-poppins commented Oct 18, 2021

mary-poppins commented Oct 18, 2021

mary-poppins commented Oct 19, 2021

AndrewKushnir left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alxhub left a comment

alxhub left a comment

alxhub left a comment

alxhub commented Oct 29, 2021

IgorMinar commented Oct 29, 2021

angular-automatic-lock-bot bot commented Nov 29, 2021