New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ordered list digits cut off #4715
Comments
|
I just tested this on v1.7.11 Ubuntun 20.04 and v1.7.5 Android 11. I could duplicate this behaviour in the viewer on android and on the WYSIWYG editor on the desktop. I could not duplicate this behaviour on the markdown editor/viewer on desktop. |
|
In noteStyle.ts , `margin-left : 1.7em ' is fixed , changing that to 2em fixes the issue ,but i guess making this dynamic will be a better choice . |
|
@singhakshita Sure, go ahead. Be sure to read the guidelines first. |
|
Is this solved? May i work on this? |
|
Well @singhakshita, i can reproduce this currently too on macOS. |
|
yeah i said that only , i was just clarifying that it might look like its adding space but actually its adding list items inside that 99th element |
|
Although @tessus , if i try to set a left margin to the ordered list to fix this, should i consider list upto 1000 or even greater? Thanks. |
|
I'm not really sure, but IMO this should be dynamic. I'm not a UI designer, but from a coding standpoint a dynamic solution would be preferable. In my case it only happens afer the 99th item and I never have numbered lists that long. |
|
On a desktop Chrome-based browser on a Mac, I can reproduce the 1000-length list problem with straight HTML, so I think correctly rendering three-digit list numbers on all platforms is sufficient. Experimentally, I've found that adding |
|
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions. |
|
May i work on this ? |
|
@harsh0032 go ahead. |
|
Is this issue solved? |
Doesn't seem so. You can try the latest pre-release and see for yourself. |
I checked and the issue still persists. Can i work on this? |
|
@Ritesh-Aggarwal you can go ahead! |
|
Hi i am not working on this anymore
…On Mon, Aug 2, 2021 at 1:28 PM PIG208 ***@***.***> wrote:
@Ritesh-Aggarwal <https://github.com/Ritesh-Aggarwal> you can go ahead!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4715 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKM72D6SORQR7WAEXBNBK6DT2ZF3VANCNFSM4ZQZUW4Q>
.
|
|
I am trying to setup for development but i am getting errors when i run npm install in root on windows |
|
@Ritesh-Aggarwal please create a post on discourse for your installation problem of the dev env. |
|
Hi. I just confirmed the issue yesterday at my Android and IOS devices. I could not go over 100. Is there any work being done on this issue? |
|
@MuhammadBilalBinAtique go ahead, but please check the previous attempts to fix this and make sure your solution is better. This is a complex problem and only correct solutions will be accepted. |
|
@CalebJohn Can you please share some views on what the correct solution will look like? |
Sorry @MuhammadBilalBinAtique, I have not looked into this problem deeply and cannot guide you in solving it. |
|
@MuhammadBilalBinAtique please do not post text as screenshots. seriously how do people come up with idiotic idea? And then please maybe search for the problem on the forum or ask there. gh is used to discuss reproducible errors. The problem is known, nothing left to discuss. So either you can come up with a PR or use the forum for questions. |











The digits in ordered lists extend into the margin and get cut off. The problem is much more severe on the iOS client, especially with wider fonts, so that "monospace" won't even show a single-digit number. On the Mac desktop client, it will at least display correctly until you hit 100 items in the list.
Environment
Joplin version: 10.7.2
Platform: iOS (iPhone XS & iPad Mini)
OS specifics: 14.4.1
Steps to reproduce
style="padding-left:16px"to make the tens digit visible.32pxto make the hundreds digit visible.Describe what you expected to happen
All digits should be visible regardless of font or length of list.
The text was updated successfully, but these errors were encountered: